Does this make any sense to anyone? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Does trading the Cross pairs makes any sense at all? 6 replies

Does advanced functional analysis make any sense? 3 replies

Order Bid/Ask: Does this make sense? 3 replies

Does that make sense to you. 6 replies

damn, this doesn't make any sense 9 replies

Does this make any sense to anyone?

  • #1
  • First Post: Jul 30, 2011 3:29pm Jul 30, 2011 3:29pm
I may be putting something in the wrong place, but (and please disregard the buy/sell orders,i'm trying to get the profit amount from a ticket) does this make any sense?
I think i'm doing something wrong with the orderselect, but I don;t know what.

Any help greatly appreciated.

Inserted Code
int intLoop;

for (intLoop=1;intLoop<51;intLoop++)

{

   if (OrderSelect(intLoop,SELECT_BY_POS)==true)
  
   {
      if (OrderProfit() > 0)
      {
         OrderSend(strSymb,OP_BUY,dblLots,Ask,intSlip,Bid-1*Point,Bid+2*Point);
      }
      else
      {
         OrderSend(strSymb,OP_SELL,dblLots,Bid,intSlip,Ask-1*Point,Ask+2*Point);
      }
   }
  • #2
  • Edited 8:48pm Jul 30, 2011 4:06pm | Edited 8:48pm
Quoting TradingNoob
I may be putting something in the wrong place, but (and please disregard the buy/sell orders,i'm trying to get the profit amount from a ticket) does this make any sense?
I think i'm doing something wrong with the orderselect, but I don;t know what.

Any help greatly appreciated.
There's nothing wrong with your OrderSelect(), assuming you're wanting to check the trades pool (pending and open orders) rather than the history pool (closed and deleted orders).

I always use the following code for an orders loop:

for (i=OrdersTotal()-1; i>=0; i--) {

Note that the first order (if SELECT_BY_POS) is #0, not #1; also, if you're having to deal with deleted orders, it's better to start from the highest numbered order (use OrdersTotal()) and work back down to zero, because deleted orders cause a renumbering of the remaining orders.

You are correct to open a new buy order at the Ask price and a new sell order at the Bid price.

OrderProfit() > 0 will return both a buy or a sell order that is in profit. Hence your code will attempt to open a new BUY order for every order that is in profit, and a new SELL order for every order that is at zero or in loss. I'm not sure if that's what you want; it seems a little strange. [EDIT] Re-read your post, I just realized that the OrderSend() is nothing more than a filler. Anyway, I'll leave the rest of my post in case it helps somebody else.

It looks like you're attempting to open orders with a TP and SL that are 2 and 1 pip respectively away from the entry point; this may be too close to the current market price for your br0ker's liking. Hence an error will be returned. Ideally, you should check for errors using GetLastError().

Point returns the size of the final (rightmost) digit, i.e. if the br0ker quotes 5/3 digit prices, then it will be 0.00001 (or 0.001 for JPY pairs), hence it is 0.1 pips, not 1 pip. To ensure my code works for all br0kers, I use something like:

double pip_value = Point;
if (Digits == 5 || Digits == 3) pip_value = Point * 10;

and then use pip_value instead of Point thereafter.

Finally, if your br0ker is ECN/STP, then you'll likely need to set the SL and TP values to 0 in your OrderSend(), and then set your desired values using a subsequent OrderModify(). Otherwise you'll get error 130 - Invalid stops.
  • #3
  • Last Post: Jul 30, 2011 4:51pm Jul 30, 2011 4:51pm
Wow, that is so awesome of you to go over the code! I was going nuts about the order select, and didnt know that the array starts at 0, not 1. Not sure why i thought that though. I really appreciate the help, you've given me a lot to think about! Thank you so much!!!
0 traders viewing now