Can't find eachtickmode bug, please help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Where can I find EA's? Please help me 7 replies

Please help find bug in my code! 1 reply

can someone help me find a ranging EA, please! 11 replies

This is a good indicator. Can someone please help me find it? 7 replies

What Does EachTickMode and TickCheck Mean? 2 replies

Can't find eachtickmode bug, please help

  • #1
  • First Post: Edited Jul 27, 2011 12:57am Jul 25, 2011 10:08pm | Edited Jul 27, 2011 12:57am
Fixed
  • #2
  • Jul 25, 2011 10:43pm Jul 25, 2011 10:43pm
how can you read that and expect to debug your own code... let alone anyone else do it for you?

it's not just you. it seems everyone in this joint has no idea how to write clean code. it only lends itself to being unreadable for the coder and those who then look to find bugs.

but... that aside. i looked for it, and straight away found what i expected. this might not solve all of your problems, but you must fix this regardless. it appears from a 10 second look-over of your code that you are opening and CLOSING orders within a for loop that cycles through all orders.

think about what you are doing when you suddenly rip one of the orders out of the order list and then iterate onto the next position in the array. you create a hole in the testing cycle where the item in the next position never gets tested.

e.g.

for 1 to 5 {

if 1 delete;

}

you will get the following sequence of events...

value = array position 1 (value = 1)
delete position 1 (positions 2,3,4,5 all shift down one position in array)
increment to next position in array
value = array position 2 (value = 3) (position 1 now has value of 2, remember, so you never see a value of 2. it's now overlooked in this entire testing cycle)
increment to next position in array
value = array position 3 (value = 4)
increment to next position in array
value = array position 4 (value = 5)
increment to next position in array
[depending on the compiler it might even attempt to read the 5th position which is now erroneous]

Inserted Code
c = 0;
while c < orderstotal() {

  if closeorder {
    close;
    c--;  <-------------- this forces a recheck of this position keeping in consideration the c++ below!!!!!
  }

  do stuff;
  do stuff;
  do stuff;

  c++;  //move to next position in array
}
Congratulations ScalaFX for coming out of the closet!
  • #3
  • Jul 26, 2011 8:59am Jul 26, 2011 8:59am
ALWAYS iterate through the open order queue in reverse :

Inserted Code
for (i=OrdersTotal()-1;i>=0;i--)
You will be glad you did...
Old Benjamin was right
  • #4
  • Last Post: Jul 26, 2011 9:02pm Jul 26, 2011 9:02pm
I wouldn't have replied if you hadn't messaged me. I am now working full time again, and I don't have much time to answer questions.

Moreover, I don't normally look at other people's EAs. I find it unnecessarily hard work trying to understand code that I didn't write myself.

The first thing that I notice is (lines 110-111) is:

double signalup=iCustom(Symbol(),0,"нформацията",0,1);
double signaldown=iCustom(Symbol(),0,"нформацията",1,1);

What does the indicator "нформацията" do?
Why have you included it in the code?
If this indicator can't be found, the EA won't place any trades - that's if I understand it correctly.

What is the EA supposed to do? Under what conditions is it supposed to enter or exit trades? You haven't provided much information.

Are you running either Vista or Win7? If so, I can not test your code, as I run only Win XP (the only version of Windows that works properly, IMO).

I'm sorry, I don't have time to pursue this any further.
0 traders viewing now