Quick EA modification needed

#1
First Post: Edited 8:57pm Jul 20, 2011 7:42pm | Edited 8:57pm

wickedwin
| Joined Apr 2011 | Status: Trader | 183 Posts

Hi,

Need some help, I tried to change the code below but the EA kept crashing MT4.

I want the order to close when the current bar (so the bar where the order was executed) closes. Basically trade one bar.

This is the original code, it trades from signal to signal.

Inserted Code

//+------------------------------------------------------------------+

//| Signal Begin(Exit Buy) |

//+------------------------------------------------------------------+



if (signaldown!=EMPTY_VALUE&&signaldown!=0) Order = SIGNAL_CLOSEBUY;





//+------------------------------------------------------------------+

//| Signal End(Exit Buy) |

//+------------------------------------------------------------------+



if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");

if (!EachTickMode) BarCount = Bars;

IsTrade = False;

continue;

}

//Trailing stop

if(UseTrailingStop && TrailingStop > 0) {

if(Bid - OrderOpenPrice() > Point * TrailingStop) {

if(OrderStopLoss() < Bid - Point * TrailingStop) {

OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);

if (!EachTickMode) BarCount = Bars;

continue;

}

}

}

} else {

//Close



//+------------------------------------------------------------------+

//| Signal Begin(Exit Sell) |

//+------------------------------------------------------------------+



if (signalup!=EMPTY_VALUE&&signalup!=0) Order = SIGNAL_CLOSESELL;





//+------------------------------------------------------------------+

//| Signal End(Exit Sell) |

//+------------------------------------------------------------------+



if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");

if (!EachTickMode) BarCount = Bars;

IsTrade = False;

continue;

}

//Trailing stop

if(UseTrailingStop && TrailingStop > 0) {

if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {

if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {

OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);

if (!EachTickMode) BarCount = Bars;

continue;

}

}

}

}

}

}



//+------------------------------------------------------------------+

//| Signal Begin(Entry) |

//+------------------------------------------------------------------+



//if (timeprev!=Time[0]){

// timeprev = Time[0];

if (signalup!=EMPTY_VALUE&&signalup!=0)

{

Order = SIGNAL_BUY;

}



if (signaldown!=EMPTY_VALUE&&signaldown!=0){

Order = SIGNAL_SELL;

}

// }

//+------------------------------------------------------------------+

//| Signal End |

//+------------------------------------------------------------------+



//Buy

if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

if(!IsTrade) {

//Check free margin

if (AccountFreeMargin() < (100 * Lots)) {

Print("We have no money. Free Margin = ", AccountFreeMargin());

return(0);

}



if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;

if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;



Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);

if(Ticket > 0) {

if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {

Print("BUY order opened : ", OrderOpenPrice());

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");

} else {

Print("Error opening BUY order : ", GetLastError());

}

}

if (EachTickMode) TickCheck = True;

if (!EachTickMode) BarCount = Bars;

return(0);

}

}



//Sell

if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {

if(!IsTrade) {

//Check free margin

if (AccountFreeMargin() < (100 * Lots)) {

Print("We have no money. Free Margin = ", AccountFreeMargin());

return(0);

}



if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;

if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;



Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);

if(Ticket > 0) {

if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {

Print("SELL order opened : ", OrderOpenPrice());

if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");

} else {

Print("Error opening SELL order : ", GetLastError());

}

}

if (EachTickMode) TickCheck = True;

if (!EachTickMode) BarCount = Bars;

return(0);

}

}



if (!EachTickMode) BarCount = Bars;



return(0);

}

//+------------------------------------------------------------------+

Can anyone help me out?

#2
Jul 20, 2011 8:58pm Jul 20, 2011 8:58pm

wickedwin
| Joined Apr 2011 | Status: Trader | 183 Posts

I also found this code,

Inserted Code

 if(data!=iTime(Symbol(),0,0))

    {

      if(signalup!=EMPTY_VALUE&&signalup!=0)

      {

        if(openpos()>0)

        {

          for(i=0;i<OrdersTotal();i++)

          if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))

          {

            if(OrderType()==OP_SELL&&OrderSymbol()==Symbol()&&OrderMagicNumber()==mn)

            {

             if(OrderClose(OrderTicket(),lots,Ask,slip))

              Print("short was closed");

            }

          }

        }

        Print("try open long");

        Print(Symbol());

        nt=OrderSend(Symbol(),OP_BUY,lots,Ask,slip,0,0,"ab",mn,0,Green);

        if(nt>0)

         Print("long order was opened");

      }

      

      if(signaldown!=EMPTY_VALUE&&signaldown!=0)

      {

        if(openpos()>0)

        {

          for(i=0;i<OrdersTotal();i++)

          if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))

          {

            if(OrderType()==OP_BUY&&OrderSymbol()==Symbol()&&OrderMagicNumber()==mn)

            {

              if(OrderClose(OrderTicket(),lots,Bid,slip))

               Print("long was closed");

            }

          }

        }

        Print("try open short");

        Print(Symbol());

        nt=OrderSend(Symbol(),OP_SELL,lots,Bid,slip,0,0,"ab",mn,0,Red);

        if(nt>0)

         Print("short was opened");

      }

      data=iTime(Symbol(),0,0);

      

    }

//----

   

//----

   return(0);

  }

//+------------------------------------------------------------------+



 int openpos()

  {

   int j=0;

   int i,n;

   n=OrdersTotal();

   for(i=0;i<n;i++)

   {

     if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)

     if(OrderSymbol()==Symbol()&&OrderMagicNumber()==mn&&(OrderType()==OP_SELL||OrderType()==OP_BUY))

     j++;

   }

   return(j);

Can any expert tell me which one is better written?

#3
Jul 20, 2011 11:52pm Jul 20, 2011 11:52pm

akukaya
| Commercial User | Joined Jul 2008 | 567 Posts

Hi,

if i understand u right, may be better to make use of NewBar function.

bool NewBar()
{ static datetime lastbar=0; datetime curbar=Time[0];
if(lastbar!=curbar) { lastbar=curbar; return (true);
} else{ return (false); }}

You can manipulate this function inside your main program.

#4
Jul 22, 2011 6:37pm Jul 22, 2011 6:37pm

wickedwin
| Joined Apr 2011 | Status: Trader | 183 Posts

bump

#5
Jul 22, 2011 7:06pm Jul 22, 2011 7:06pm

jm8985
| Joined Mar 2010 | Status: Trader | 74 Posts

Or you could just test the volume, if your trading logic is contained in a function:

Inserted Code

void LookForTradingOpportunities()
{

   if(Volume[0]>1) return; //run only after close
   if ( (HCCILevel > CCIHighTrigger) && (HCCILevel > Prev_HCCILevel) && (LCCILevel < CCILowTrigger)) {
   
           Order = SIGNAL_BUY;
            
         }
  if ( (HCCILevel < CCILowTrigger) && (HCCILevel < Prev_HCCILevel) && (LCCILevel > CCIHighTrigger)) {
   
           Order = SIGNAL_SELL;
            
         }

}//END

#6
Last Post: Edited 10:35pm Jul 22, 2011 9:08pm | Edited 10:35pm

wickedwin
| Joined Apr 2011 | Status: Trader | 183 Posts

Fixed, used

Inserted Code

int barsCount = 0;


int init()
{

   return(0);
}


int deinit()
{
   return(0);
}


int start()
{
   if(Bars > barsCount){
      if(OrdersTotal() > 0){
         for(int c = 0; c < OrdersTotal(); c++){
            OrderSelect(c, SELECT_BY_POS);
      
            if(OrderType() == OP_BUY){
               OrderClose(OrderTicket(), OrderLots(), Bid, 3, Blue);
            }else if(OrderType() == OP_SELL){
               OrderClose(OrderTicket(), OrderLots(), Ask, 3, Red);
            }
         }
       }
       
    
    
   barsCount = Bars;
   
   return(0);

Platform Tech
/
Quick EA modification needed
Reply to Thread

0 traders viewing now

Options

Similar Threads

Quick EA modification needed