Requesting Assistance with my MA/RSI EA

Hello guys, this is an EA that I created with that website (I forgot the name) and tweaked myself. It's actually a pretty good EA except for one thing. When it loses, it loses BIG. This seems due to the fact that it will not close orders immediately when the price goes over the Slow MA. I've tried implementing realtime checks like:

The above statements should stop a buy if the two previous bars close in a down trend but for some reason it will not close on these conditions as intended. Also enacting a S/L seems to have a bad effect on the overall performance of the EA as well.

Any assistance would be appreciated. Check out the report and you'll see that it has potential. Over the past year and a half it would have turned $3000 into about $60k. This might not sound impressive however the total profit was $330k which means it botched a lot of trades.

Suggested settings:
EURUSD
M30
EachTick Mode = True
Trailing Stop = 60

I'm using a Demo account on FXOpen

Hi Purger,

I haven't looked at the code yet, will do so later today, but just based on your code snippet your logic may not be accurate. Here is my trail of thought:


Both of these code snippets read to me as follows -> if close of bar previous to the previous bar is less than close of previous bar (i.e. price for the last two bars has been going up), then EA should close the buy order. Obviously this is opposite of your statement (i.e. prices are not going down)

I think what you need is to code it so that

.

Again, this is a quick response just to get you thinking, I will look deeper in the code and report back.

Cheers,

Thanks Dr. Pip, I'll take a look and see if I'm just doing it backwards. Hopefully it's not something that simple. Also You'll notice the following code in the init function:
I was just messing around with money management stuff. Plus it's in the wrong place to really make a difference anyway.

Wow, I made the change and it made a sizeable difference. Sometimes it's hard for me to tell computers what to do. Though, the change did not have the desired effect it's still a step in the right direction.

MT4's backtest feature isn't exactly the greatest, sometimes it will show results based on completely false entry and exit criteria that look really good. To combat this issue you have to make sure that your entry and exit criteria are sound before you code them. I find it very helpful to write down the criteria first then translate them into code. This helps me in getting things straight and that the expression I am coding actually represents the criteria.

I believe I have a good system. It's just hard to break it down for a computer to understand.

True, hence why I recommend writing it down, because when you do, you will have to translate each condition into code as your are reading it out loud