Joined Jul 2009
|
Status: ...or there about!
|220 Posts
Although the indicator is different, the issues are related so I haven't started a new thread.
The purpose of the attached indicator is to allow the user to mark out bar counts with vertical lines which are relative to an independent (added separately by the user) vertical line object named, "BarCount" (referred to below as the origin). The indicator monitors the location of this object and redraws the objects if a change in location is detected.
This all works as expected on the same timeframe, however, if I move the origin on a weekly chart, then drop down to a daily chart, the indicator does not redraw the lines. I can work around this by moving the origin on the daily chart - the indicator then draws the lines as expected but, I'd rather not have to do this.
What I would expect to happen is; Deint() executes before the timeframe is changed and all of the objects are deleted then, Init() executes, checks for the origin object, determines the time value then, calls the UDF to draw the lines then, monitor the origin...
As the indicator redraws after I move the origin, I believe that the code in my start() function is working correctly so, the problem seems to be in Init()...
Therefore, I will be very grateful if somebody could cast a fresh pair of eyes over my code and let me know if I messed up somewhere...
Although the indicator is different, the issues are related so I haven't started a new thread.
The purpose of the attached indicator is to allow the user to mark out bar counts with vertical lines which are relative to an independent (added separately by the user) vertical line object named, "BarCount" (referred to below as the origin). The indicator monitors the location of this object and redraws the objects if a change in location is detected.
This all works as expected on the same timeframe, however, if I move the origin on a weekly...
Ignored
Hi.
I modified your indi to
a) Automatically draw the origin line if it starts and there is none. I have set it at bar 3 but you may want to add some checking code to see if you have 3 or any bars.
b) Refresh and draw lines as I believe you expect when changing tf's
The trick is to be more forceful in the init area and instead of the if else statement, just call two if statements.
Inserted Code
int init(){
if(ObjectFind(strOriginBar) == -1){ // If the bar is not on the chart, objectfind will return -1
//Alert("Origin bar cannot be located!");
Alert("Origin bar cannot be located! Creating Now");
ObjectCreate (strOriginBar,OBJ_VLINE,0,Time[3],0);// If the returned value was -1 then the alert user
}
if(ObjectFind(strOriginBar) != -1){
//Alert("Origin bar has been located!"); // If the returned value wasn't -1 then the alert user
intTimeFrame = Period(); // Initialise the period function and store the result
dteOldTime = ObjectGet(strOriginBar,OBJPROP_TIME1); // Find the time value of the bar;
UDF_DeleteCounts();
UDF_DrawCounts(dteOldTime,intTimeFrame); // Call the user defined function to draw the vertical lines
} // End of if statement
return(0);
}
