Modified Trailing Stop Routine

Here's a routine that I am testing. It seems that the sell side stop is trailing on step one only, and the buy stop is not trailing whatsoever. I'm not sure if there is something wrong with the logic or syntax. What is the problem here?

*********

int step1 = 9, step2 = 18, step3 = 27;
for (int i = 0; i <= 0; i++) //scan all orders & positions...
{
OrderSelect (i, SELECT_BY_POS, MODE_TRADES);
{
if ((OrderSymbol() != Symbol()) && ((OrderMagicNumber() != magic + buy_id) || (OrderMagicNumber() != magic + sell_id))) continue;
{
if (OrderType() <= OP_SELL)
{
if ((short < (OrderOpenPrice() - step1 * Point)) && (short > (OrderOpenPrice() - step2 * Point)))
{
OrderModify (OrderTicket(), short, short + step1 * Point, OrderTakeProfit(), 0, Gold);
} else
if ((short < (OrderOpenPrice() - step2 * Point)) && (short > (OrderOpenPrice() - step3 * Point)))
{
OrderModify (OrderTicket(), short, short + step1 * Point, OrderTakeProfit(), 0, Tomato);
} else
if (short < (OrderOpenPrice() - step3 * Point))
{
OrderModify (OrderTicket(), short, short + step1 * Point, OrderTakeProfit(), 0, Coral);
}
} else
if (OrderType() >= OP_BUY)
{
if ((long > (OrderOpenPrice() + step1 * Point)) && (long < (OrderOpenPrice() + step2 * Point)))
{
OrderModify (OrderTicket(), long, long - step1 * Point, OrderTakeProfit(), 0, Gold);
} else
if ((long > (OrderOpenPrice() + step2 * Point)) && (long < (OrderOpenPrice() + step3 * Point)))
{
OrderModify (OrderTicket(), long, long - step1 * Point, OrderTakeProfit(), 0, Tomato);
} else
if (long > (OrderOpenPrice() + step3 * Point))
{
OrderModify (OrderTicket(), long, long - step1 * Point, OrderTakeProfit(), 0, Coral);
}
}
}
}
}

*********

for (int i = 0; i <= 0; i++)

this statement will only execute one time before i becomes larger than 0. Try it this way:

for (int i = 0; i <= Orderstotal(); i++)

Thanks for that code adjustment. I implemented it and so far the results are exactly the same for a couple of backtests.

One thing that still happening is that long trades are not being stop adjusted, but short trades are.

Can anyone see where the code might be wrong logically that could cause buy side stop adjustments to not modify?

Thanks in advance.

it is best to post all of the code when asking for help. Without it simple things like where "long" and "short" variables are being declared and/or set cannot be determined.

OP_SELL and OP_BUY is a constant which have the value:
OP_BUY = 0
OP_SELL = 1

so, this code:
if (OrderType() <= OP_SELL) which is identical to "if (OrderType() <= 1)"
will always be executed wether the OrderType() value is 0 for buying or 1 for selling.

that's why the code below
} else
if (OrderType() >= OP_BUY)
{

will never be executed.

you should using
if (OrderType() == OP_SELL)
and
if (OrderType() == OP_BUY).

regarding the program logic, i don't understand what the objective of your program, except gold, tomato and coral (it seems the objective of the if-else condition only to set the color of the trailing stop?) i think, like magnum said, it's better to post all the code.

Thanks Sangmane for the explanation.

I did try == before you replied and it did work and triggered the trailing stops on both sides, but the results were not as good as just sell orders trailing.

However, I appreciate very much your explanation as to why the sells were the only stops trailing. That makes complete sense.

Now a general question which maybe should be posted in the trading systems thread...

Has this happened to you...

Your EA performs better with just a trailing stop on buy orders or just a trailing stop on sell orders, but not on both sides. Interesting.