Can Someone Help to Modify this Pivot Indicator

Hi My Friends, http://www.forex-tsd.com/images/smilies/hail.gif

Greetings ! Need help.

I posted the following code taken from the existing MT4 file hope someone who able to help to modify and add in the the followings:

1. LocalTimeZone.
2. Vertical line show on Today, yesterday & Beforeyesterday.
3. Pivot Resistance & Support 1, 2 & 3.

Attached an image for viewing.
Your kind assistant is appreciated. http://www.forex-tsd.com/images/smilies/hail.gif



The Code as as below:

//+------------------------------------------------------------------+
//| HiLo2DayBefore.mq4 |
//+------------------------------------------------------------------+

#property indicator_chart_window
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//----
//YLow, low of yesterday.
//YHigh, high of yesterday.
//B4YLow, low of before yestersay.
//B4YHigh, high of before yesterday.
//PP, pivot point.
ObjectDelete("YLow");
ObjectDelete("B4YLow");
ObjectDelete("YHigh");
ObjectDelete("B4YHigh");
ObjectDelete("PIVOT");
Comment(" ");
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{

//----
double yesterday_close,yesterday_high,yesterday_low,before_yesterday_close,before_yesterday_high,before_yesterday_low;

yesterday_close = iClose(NULL,PERIOD_D1,1);
yesterday_high = iHigh(NULL,PERIOD_D1,1);
yesterday_low = iLow(NULL,PERIOD_D1,1);
before_yesterday_close = iClose(NULL,PERIOD_D1,2);
before_yesterday_high = iHigh(NULL,PERIOD_D1,2);
before_yesterday_low = iLow(NULL,PERIOD_D1,2);

//---- Calculate Pivots

//Comment("\nYesterday quotations :\nH ",yesterday_high,"\nL ",yesterday_low, "\nC ",yesterday_close,"\n\nBefore yesterday quotations :\nH ",before_yesterday_high,"\nL ",before_yesterday_low, "\nC ",before_yesterday_close);
double pivot = (yesterday_high + yesterday_low + yesterday_close)/3;// Standard Pivot

drawLine(yesterday_low,"YLow", Plum,0);
drawLabel("Low yesterday",yesterday_low,Plum);
drawLine(before_yesterday_low,"B4YLow", Plum,0);
drawLabel("Low before yesterday",before_yesterday_low,Plum);

drawLine(pivot,"PIVOT",Aqua,1);
drawLabel("Pivot level",pivot,Aqua);

drawLine(yesterday_high,"YHigh",CornflowerBlue,0);
drawLabel("High yesterday",yesterday_high,CornflowerBlue);
drawLine(before_yesterday_high,"B4YHigh",CornflowerBlue,0);
drawLabel("High before yesterday",before_yesterday_high,CornflowerBlue);


//----
return(0);
}
//+------------------------------------------------------------------+
void drawLabel(string name,double lvl,color Color)
{
if(ObjectFind(name) != 0)
{
ObjectCreate(name, OBJ_TEXT, 0, Time[10], lvl);
ObjectSetText(name, name, 8, "Arial", EMPTY);
ObjectSet(name, OBJPROP_COLOR, Color);
}
else
{
ObjectMove(name, 0, Time[10], lvl);
}
}


void drawLine(double lvl,string name, color Col,int type)
{
if(ObjectFind(name) != 0)
{
ObjectCreate(name, OBJ_HLINE, 0, Time[0], lvl,Time[0],lvl);

if(type == 1)
ObjectSet(name, OBJPROP_STYLE, STYLE_SOLID);
else
ObjectSet(name, OBJPROP_STYLE, STYLE_DOT);

ObjectSet(name, OBJPROP_COLOR, Col);
ObjectSet(name,OBJPROP_WIDTH,1);

}
else
{
ObjectDelete(name);
ObjectCreate(name, OBJ_HLINE, 0, Time[0], lvl,Time[0],lvl);

if(type == 1)
ObjectSet(name, OBJPROP_STYLE, STYLE_SOLID);
else
ObjectSet(name, OBJPROP_STYLE, STYLE_DOT);

ObjectSet(name, OBJPROP_COLOR, Col);
ObjectSet(name,OBJPROP_WIDTH,1);

}
}

Harry check this out TigertronPivots I think it is what you are looking for.

Hello Tigertron,

Many thank for your respond. I could not get anything out from your version.

I had corrected many versions of pivot / camarilla and have never ever come across a version function with “High / Low of the session before the previous session”, most of them are “High / Low of the previous session”.

I did modified but end up the “High / Low of the session before the previous session” does not work, can you or others may help to look at it how to make it work.

Thank you



#property indicator_chart_window
//---- input parameters
extern int GMTshift=-3;
//+------------------------------------------------------------------+
//| Custom indicator initialization function |
//+------------------------------------------------------------------+
int init()
{
//---- indicators
//----
return(0);
}
//+------------------------------------------------------------------+
//| Custor indicator deinitialization function |
//+------------------------------------------------------------------+
int deinit()
{
//---- TODO: add your code here

//YLow, low of yesterday.
//YHigh, high of yesterday.
//B4YLow, low of before yestersay.
//B4YHigh, high of before yesterday.
//PP, pivot point.
ObjectDelete("YLow");
ObjectDelete("B4YLow");
ObjectDelete("YHigh");
ObjectDelete("B4YHigh");
ObjectDelete("PIVOT");
Comment(" ");
//----
return(0);
}

//+------------------------------------------------------------------+
//| Custom indicator iteration function |
//+------------------------------------------------------------------+
int start()
{
int counted_bars=IndicatorCounted();
//---- TODO: add your code here
double day_high=0;
double day_low=0;
double today_open=0;
double yesterday_high=0;
double yesterday_open=0;
double yesterday_low=0;
double yesterday_close=0;
double before_yesterday_high=0;
double before_yesterday_low=0;
double before_yesterday_close=0;

double P=0,S=0,R=0,S1=0,R1=0,S2=0,R2=0,S3=0,R3=0;
int cnt=720;
double cur_day=0;
double prev_day=0;

//Define the high/low of yesterday & beforeyesterday

yesterday_close = iClose(NULL,PERIOD_H1,1);
yesterday_high = iHigh(NULL,PERIOD_H1,1);
yesterday_low = iLow(NULL,PERIOD_H1,1);
before_yesterday_close = iClose(NULL,PERIOD_H1,2);
before_yesterday_high = iHigh(NULL,PERIOD_H1,2);
before_yesterday_low = iLow(NULL,PERIOD_H1,2);

//---- exit if period is greater than daily charts
if(Period() > 1440)
{
Print("Error - Chart period is greater than 1 day.");
return(-1); // then exit
}

//---- Get new daily prices & calculate pivots

while (cnt!= 0)
{
cur_day = TimeDay(Time[cnt]- (GMTshift*3600));

if (prev_day != cur_day)
{
yesterday_close = Close[cnt+1];
today_open = Open[cnt];
yesterday_high = day_high;
yesterday_low = day_low;

day_high = High[cnt];
day_low = Low[cnt];

prev_day = cur_day;
}

if (High[cnt]>day_high)
{
day_high = High[cnt];
}
if (Low[cnt]<day_low)
{
day_low = Low[cnt];
}

// SetIndexValue(cnt, 0);
cnt--;

}

//------ Calculate Pivot Points ------

P = (yesterday_high + yesterday_low + yesterday_close)/3;
R1 = (2*P)-yesterday_low;
S1 = (2*P)-yesterday_high;
R2 = P-S1+R1;
S2 = P-R1+S1;
R3 = (2*P)+(yesterday_high-(2*yesterday_low));
S3 = (2*P)-((2* yesterday_high)-yesterday_low);



//------ DRAWING LINES ------

//Comment("nYesterday quotations :nH ",yesterday_high,"nL ",yesterday_low, "nC ",yesterday_close,"nnBefore yesterday quotations :nH ",before_yesterday_high,"nL ",before_yesterday_low, "nC ",before_yesterday_close);
double pivot = (yesterday_high + yesterday_low + yesterday_close)/3;// Standard Pivot

drawLine(yesterday_low,"YLow", Plum,0);
drawLabel("Y's Low",yesterday_low,Plum);
drawLine(before_yesterday_low,"B4YLow", Plum,0);
drawLabel("B4 Y's Low",before_yesterday_low,Plum);

drawLine(pivot,"PIVOT",Aqua,1);
drawLabel("Pivot Level",pivot,Aqua);

drawLine(yesterday_high,"YHigh",CornflowerBlue,0);
drawLabel("Y's High",yesterday_high,CornflowerBlue);
drawLine(before_yesterday_high,"B4YHigh",CornflowerBlue,0);
drawLabel("B4 Y's High",before_yesterday_high,CornflowerBlue);


//ObjectDelete("P_Line");

ObjectDelete("S3_Line");
ObjectDelete("R3_Line");

ObjectDelete("S2_Line");
ObjectDelete("R2_Line");

ObjectDelete("S1_Line");
ObjectDelete("R1_Line");


//ObjectCreate("P_Line", OBJ_HLINE,0, CurTime(),P);
//ObjectSet("P_Line",OBJPROP_COLOR,DeepPink);
//ObjectSet("P_Line",OBJPROP_STYLE,STYLE_SOLID);

ObjectCreate("S3_Line", OBJ_HLINE,0, CurTime(),S3);
ObjectSet("S3_Line",OBJPROP_COLOR,Red);
ObjectSet("S3_Line",OBJPROP_STYLE,STYLE_DOT);

ObjectCreate("R3_Line", OBJ_HLINE,0, CurTime(),R3);
ObjectSet("R3_Line",OBJPROP_COLOR,Blue);
ObjectSet("R3_Line",OBJPROP_STYLE,STYLE_DOT);

ObjectCreate("S2_Line", OBJ_HLINE,0, CurTime(),S2);
ObjectSet("S2_Line",OBJPROP_COLOR,Red);
ObjectSet("S2_Line",OBJPROP_STYLE,STYLE_DOT);

ObjectCreate("R2_Line", OBJ_HLINE,0, CurTime(),R2);
ObjectSet("R2_Line",OBJPROP_COLOR,Blue);
ObjectSet("R2_Line",OBJPROP_STYLE,STYLE_DOT);

ObjectCreate("S1_Line", OBJ_HLINE,0, CurTime(),S1);
ObjectSet("S1_Line",OBJPROP_COLOR,Red);
ObjectSet("S1_Line",OBJPROP_STYLE,STYLE_DOT);

ObjectCreate("R1_Line", OBJ_HLINE,0, CurTime(),R1);
ObjectSet("R1_Line",OBJPROP_COLOR,Blue);
ObjectSet("R1_Line",OBJPROP_STYLE,STYLE_DOT);


ObjectsRedraw();

// --- Typing Labels

if(ObjectFind("R3 label") != 0)
{
ObjectCreate("R3 label", OBJ_TEXT, 0, Time[0], R3);
ObjectSetText("R3 label", " R3 ", 8, "Arial", Blue);
}
else
{
ObjectMove("R3 label", 0, Time[0], R3);
}

if(ObjectFind("S3 label") != 0)
{
ObjectCreate("S3 label", OBJ_TEXT, 0, Time[0], S3);
ObjectSetText("S3 label", " S3 ", 8, "Arial", Red);
}
else
{
ObjectMove("S3 label", 0, Time[0], S3);
}

if(ObjectFind("R2 label") != 0)
{
ObjectCreate("R2 label", OBJ_TEXT, 0, Time[0], R2);
ObjectSetText("R2 label", " R2 ", 8, "Arial", Blue);
}
else
{
ObjectMove("R2 label", 0, Time[0], R2);
}

if(ObjectFind("S2 label") != 0)
{
ObjectCreate("S2 label", OBJ_TEXT, 0, Time[0], S2);
ObjectSetText("S2 label", " S2 ", 8, "Arial", Red);
}
else
{
ObjectMove("S2 label", 0, Time[0], S2);
}

if(ObjectFind("R1 label") != 0)
{
ObjectCreate("R1 label", OBJ_TEXT, 0, Time[0], R1);
ObjectSetText("R1 label", " R1 ", 8, "Arial", Blue);
}
else
{
ObjectMove("R1 label", 0, Time[0], R1);
}

if(ObjectFind("S1 label") != 0)
{
ObjectCreate("S1 label", OBJ_TEXT, 0, Time[0], S1);
ObjectSetText("S1 label", " S1 ", 8, "Arial", Red);
}
else
{
ObjectMove("S1 label", 0, Time[0], S1);
}

//if(ObjectFind("P label") != 0)
{
//ObjectCreate("P label", OBJ_TEXT, 0, Time[0], P);
//ObjectSetText("P label", " P ", 8, "Arial", DeepPink);
}
//else
{
//ObjectMove("P label", 0, Time[0], P);
}
return(0);
}
//+------------------------------------------------------------------+
//| Helper |
//+------------------------------------------------------------------+

void drawLabel(string name,double lvl,color Color)
{
if(ObjectFind(name) != 0)
{
ObjectCreate(name, OBJ_TEXT, 0, Time[10], lvl);
ObjectSetText(name, name, 8, "Arial", EMPTY);
ObjectSet(name, OBJPROP_COLOR, Color);
}
else
{
ObjectMove(name, 0, Time[10], lvl);
}
}

//+------------------------------------------------------------------+
//| Helper |
//+------------------------------------------------------------------+
void drawLine(double lvl,string name, color Col,int type)
{
if(ObjectFind(name) != 0)
{
ObjectCreate(name, OBJ_HLINE, 0, Time[0], lvl,Time[0],lvl);

if(type == 1)
ObjectSet(name, OBJPROP_STYLE, STYLE_SOLID);
else
ObjectSet(name, OBJPROP_STYLE, STYLE_DOT);

ObjectSet(name, OBJPROP_COLOR, Col);
ObjectSet(name,OBJPROP_WIDTH,1);

}
else
{
ObjectDelete(name);
ObjectCreate(name, OBJ_HLINE, 0, Time[0], lvl,Time[0],lvl);

if(type == 1)
ObjectSet(name, OBJPROP_STYLE, STYLE_SOLID);
else
ObjectSet(name, OBJPROP_STYLE, STYLE_DOT);

ObjectSet(name, OBJPROP_COLOR, Col);
ObjectSet(name,OBJPROP_WIDTH,1);

}
}

This indicator is what I was referring too. It should work. I can't imagine why it wouldn't.

Hi Tigertron,

Thank you for your awesome indicator.

I really overlook that, thanks for alerting him. I really like this indicator, the Indicator I attached on chat it come out non stop alert showing "Time zone error". What's strong with the timezone set up (remain as at your set up), any way to fit it?

Lastly, how could I change the lines color setting? Your advise please!

Looking forward to your final version.

May God bless you.

Hi Admin,

My matter closed.

Thanks