EA wont execute trades! just alerts...

Hi guys,

I built an EA from this place here:
http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/

Now I have completed the thing and it loads onto MT4 charts correctly.... gives a buy/sell Alert (even though I cant see the function to enable that) but it wont execute the trade according to the parameters i have asked!

I have allowed "live trading" and disabled "ask for manual conformation".

Where should I be looking/adding???????

Oh - and I have placed it in this folder: C:\Program Files\MetaTrader4\experts

THKS in advance!

look in the journal to see if you are getting any error messages and post the EA if you can.

Journal is fine. no errors visible. also there is no error file in the experts folder.

ah, the EA....

------------------------------------------------------------------------

//+------------------------------------------------------------------+
//| This MQL is generated by Expert Advisor Builder |
//| http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/ |
//| |
//| In no event will author be liable for any damages whatsoever. |
//| Use at your own risk. |
//| |
//+------------------- DO NOT REMOVE THIS HEADER --------------------+

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4

#property copyright "Expert Advisor Builder"
#property link "http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/"

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = False;
extern double Lots = 1;
extern int Slippage = 3;
extern bool UseStopLoss = True;
extern int StopLoss = 30;
extern bool UseTakeProfit = True;
extern int TakeProfit = 45;
extern bool UseTrailingStop = True;
extern int TrailingStop = 30;

int BarCount;
int Current;
bool TickCheck = False;
//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+
int start() {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;



if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;

//+------------------------------------------------------------------+
//| Variable Begin |
//+------------------------------------------------------------------+

double Var1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Var2 = iMA(NULL, 0, 10, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Var3 = iMA(NULL, 0, 7, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Var4 = iCustom(NULL, 0, "Slope Direction Line", 0, Current + 0);
double Var5 = iCustom(NULL, 0, "HMA Russian Histo", 0, Current + 0);
double Var6 = Red;
double Var7 = Blue;
double Var8 = LightBlue;

double Buy1_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Buy1_2 = Var7 ;
double Buy2_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Buy2_2 = iMA(NULL, 0, 10, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Buy3_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Buy3_2 = iMA(NULL, 0, 7, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Buy4_1 = iCustom(NULL, 0, "HMA Russian Histo", 0, Current + 0);
double Buy4_2 = Var7 ;
double Buy5_1 = iCustom(NULL, 0, "Slope Direction Line", 0, Current + 0);
double Buy5_2 = Var8 ;

double Sell1_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Sell1_2 = Var6 ;
double Sell2_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Sell2_2 = iMA(NULL, 0, 10, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Sell3_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double Sell3_2 = iMA(NULL, 0, 7, 0, MODE_SMA, PRICE_CLOSE, Current + 0);
double Sell4_1 = iCustom(NULL, 0, "HMA Russian Histo", 0, Current + 0);
double Sell4_2 = Var6 ;
double Sell5_1 = iCustom(NULL, 0, "Slope Direction Line", 0, Current + 0);
double Sell5_2 = Var6 ;

double CloseBuy1_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double CloseBuy1_2 = Var6 ;
double CloseBuy2_1 = iCustom(NULL, 0, "HMA Russian Histo", 0, Current + 0);
double CloseBuy2_2 = Var6 ;

double CloseSell1_1 = iCustom(NULL, 0, "HMA Modified", 0, Current + 0);
double CloseSell1_2 = Var7 ;
double CloseSell2_1 = iCustom(NULL, 0, "HMA Russian Histo", 0, Current + 0);
double CloseSell2_2 = Var7 ;


//+------------------------------------------------------------------+
//| Variable End |
//+------------------------------------------------------------------+

//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Buy) |
//+------------------------------------------------------------------+

if (CloseBuy1_1 == CloseBuy1_2 && CloseBuy2_1 == CloseBuy2_2) Order = SIGNAL_CLOSEBUY;


//+------------------------------------------------------------------+
//| Signal End(Exit Buy) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close

//+------------------------------------------------------------------+
//| Signal Begin(Exit Sell) |
//+------------------------------------------------------------------+

if (CloseSell1_1 == CloseSell1_2 && CloseSell2_1 == CloseSell2_2) Order = SIGNAL_CLOSESELL;


//+------------------------------------------------------------------+
//| Signal End(Exit Sell) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) {
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+

if (Buy1_1 == Buy1_2 && Buy2_1 > Buy2_2 && Buy3_1 > Buy3_2 && Buy4_1 == Buy4_2 && Buy5_1 == Buy5_2) Order = SIGNAL_BUY;

if (Sell1_1 == Sell1_2 && Sell2_1 < Sell2_2 && Sell3_1 < Sell3_2 && Sell4_1 == Sell4_2 && Sell5_1 == Sell5_2) Order = SIGNAL_SELL;


//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

if (!EachTickMode) BarCount = Bars;

return(0);
}
//+------------------------------------------------------------------+

make sure you have all of the indicators listed in the "Variable Begin" section. Make sure they are all spelled right and are exactly the same as what you have in your experts/indicators folders. Right down to the capitalization and spaces.

you need to make sure that you are getting information from the right part of the indicators. all of the ones listed in your variable begin section reference the first buffer. most likely with a histogram there will be more than one buffer used.

sorry pardon my ignorance..... referencing the first buffer..... may u please explain.... or point me to where i can find out about the buffer for indicators?

Thanks magnumfreak for your quick replies!

......By buffer you mean the current price/status of the variable/indicator?

you have the hull var 7 set to blue or whateva it needs to be set to value2 or value1 which ever the indicator calls the color...if that doesnt work i have a working copy i made that you use <> > and a number it works but only after close of a candle