Is this indicator difficult to program in mql?

Quoting thatwasme

Disliked

It already exists. It is Team Aphid's Bat indicator. Just change the settings to 20 and 2 and it is the same thing. It is a ATR multipler regression stop indicator just like VSTOP.

I fact, the BAT indicator is more responsive and does not repaint the second bar the way the logic in VSTOP does.

http://www.forexfactory.com/showpost...7&postcount=35

Ignored

When Up Trend Detected....
   VSTOP = CL - MULT * TRAs Up Trend            Continues....
   VSTOP = MAX(VSTOP.1, MaxCL - MULT * TR)
           When Down Trend Detected....
   VSTOP = CL + MULT * TR
           As Down Trend Continues....
   VSTOP = MIN(VSTOP.1, MinCL + MULT * TR)
           Where...
     CL = Closing Price
     MULT = True Range Multiplier
     TR = True Range
     VSTOP.1 = Volatility Stop Value on Previous Bar
     MaxCL = Maximum Closing Price since Up Trend Began
     MinCL = Minimum Closing Price since Down Trend Began
   Trend reverses between up and down when Closing Price crosses VSTOP. 

Quoting thatwasme

Disliked

I just went line by line through the program and it is exactly the same logic, only the period of the atr is different and the factor

In VSTOP factor is MULT and ATRPeriod is TrueRange

The programmed logic is identical to this formula

[php]When Up Trend Detected.......

Ignored

//+------------------------------------------------------------------+
//|                                            ATR Trailing Stop.mq4 |
//|                                                                  |
//|                                                                   |
//+------------------------------------------------------------------+
#property  copyright "Copyright Team Aphid"
#property  link      ""
//---- indicator settings
#property  indicator_chart_window
#property  indicator_buffers 2
#property  indicator_color1  Blue
#property  indicator_color2  Red

//---- indicator parameters
extern int BackPeriod   = 1000;
extern int ATRPeriod   = 3;
extern double Factor = 3;
extern bool TypicalPrice = false;

//---- indicator buffers
double     ind_buffer1[];
double     ind_buffer2[];

//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- drawing settings  
   SetIndexStyle(0,DRAW_LINE,EMPTY,2);
   SetIndexDrawBegin(0,ATRPeriod);
   SetIndexBuffer(0,ind_buffer1);
   SetIndexShift(0,1);
   SetIndexStyle(1,DRAW_LINE,EMPTY,2);
   SetIndexDrawBegin(1,ATRPeriod);
   SetIndexBuffer(1,ind_buffer2);

   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS)+2);
//---- name for DataWindow and indicator subwindow label
   IndicatorShortName("ATR Trailing Stop("+ATRPeriod+" * "+Factor+")");
   SetIndexLabel(0,"Support");
   SetIndexLabel(1,"Resistance");
//---- initialization done
   return(0);
  }
//+------------------------------------------------------------------+
//| Moving Averages Convergence/Divergence                           |
//+------------------------------------------------------------------+
int start()
  {
   int limit;
   int counted_bars=IndicatorCounted();
   double PrevUp, PrevDn;
   double CurrUp, CurrDn;
   double PriceLvl;
   double LvlUp = 0;
   double LvlDn = 1000;
   int Dir = 1;
   int InitDir;
//---- check for possible errors
   if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;
//---- fill in buffervalues
   InitDir = 0;
   for(int i=BackPeriod; i>=0; i--)
   {
      if (TypicalPrice) PriceLvl = (High[i] + Low[i] + Close[i])/3;
      else PriceLvl = Close[i];  

//>>>>>>>>>>>  Values for test for VSTOP to check for a cross <<<<<<<<<<<<<<<<
//                      and the close[i-1] is the self reference for VSTOP.1
      if(InitDir == 0) {
         CurrUp=Close[i] - (iATR(NULL,0,ATRPeriod,i) * Factor);
         PrevUp=Close[i-1] - (iATR(NULL,0,ATRPeriod,i-1) * Factor);
         CurrDn=Close[i] + (iATR(NULL,0,ATRPeriod,i) * Factor);
         PrevDn=Close[i-1] + (iATR(NULL,0,ATRPeriod,i-1) * Factor);

//  >>>>>>>>>>>>>>>>>>>>  Establishing the firs intitial value for VSTOP <<<<<<<<<<<<<          
         if (CurrUp > PrevUp) Dir = 1;
         LvlUp = CurrUp;
         if (CurrDn < PrevDn) Dir = -1;
         LvlDn = CurrDn;
         InitDir = 1;
       
      }

// >>>>>>>>>>>  Seting up values for the first VSTOP on a new trend <<<<<<<<<<<<<<<<<<      
      CurrUp=PriceLvl - (iATR(NULL,0,ATRPeriod,i) * Factor);
      CurrDn=PriceLvl + (iATR(NULL,0,ATRPeriod,i) * Factor);

// >>>>>>>>>>>>>>  VSTOP = MAX(VSTOP.1, MaxCL - MULT * TR)  <<<<<<<<<<<<<<<<<<<<<<<
      if (Dir == 1) {
         if (CurrUp > LvlUp) {
            ind_buffer1[i] = CurrUp;
            LvlUp = CurrUp;
         }
         else {
            ind_buffer1[i] = LvlUp;
         }
         
//  >>>>>>>>>>>>>>>>  Stops the continous line drawing  <<<<<<<<<<<<<<<<<<<<<<         
         ind_buffer2[i] = EMPTY_VALUE;
         if (Low[i] < ind_buffer1[i]) {
            Dir = -1;
            LvlDn = 1000;
         }
      }

// >>>>>>>>>>>  VSTOP = MIN(VSTOP.1, MinCL + MULT * TR) <<<<<<<<<<<<<<<<<<<<<<      
      if (Dir == -1) {
         if (CurrDn < LvlDn) {
            ind_buffer2[i] = CurrDn;
            LvlDn = CurrDn;
         }
         else {
            ind_buffer2[i] = LvlDn;
         }

//  >>>>>>>>>>>>>>>>  Stops the continous line drawing  <<<<<<<<<<<<<<<<<<<<<<         
         ind_buffer1[i] = EMPTY_VALUE;
         if (High[i] > ind_buffer2[i]) {
            Dir = 1;
            LvlUp = 0;
         }
      }
 
   }  
   

//---- done
   return(0);
  }