AI talking

Quote

Disliked

Allow opening only one order at time

#property copyright "Copyright 2019, MyCompany"
#property link      "https://www.mycompany.com"
#property version   "1.00"
#property strict
input double StopLoss = 100.0;
input double TakeProfit = 200.0;
input double DipPercent = 5.0;
int OnInit()
{
    // Initialize the expert
    return(INIT_SUCCEEDED);
}
void OnTick()
{
    // Check if the bar has just opened
    if (TimeCurrent() == Time[0])
    {
        // Calculate the dip percentage
        double dip = (Low[1] - Low[2]) / Low[2] * 100;
        // Check if the current price is below the previous low by the dip percentage
        if (dip >= DipPercent)
        {
            // Check if there is already an open order
            if (OrdersTotal() == 0)
            {
                // If it is, buy at market price
                OrderSend(Symbol(), OP_BUY, 1, Ask, 3, Ask - StopLoss * Point, Ask + TakeProfit * Point);
            }
        }
        // Check if the stop loss or take profit levels have been reached
        for (int i = OrdersTotal() - 1; i >= 0; i--)
        {
            if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
            {
                if (OrderType() == OP_BUY)
                {
                    if (Bid <= OrderStopLoss() || Bid >= OrderTakeProfit())
                    {
                        OrderClose(OrderTicket(), OrderLots(), Bid, 3, CLR_NONE);
                    }
                }
            }
        }
    }
}

Quote

Disliked

Add Magic number and control opened orders count by Magic number

#property copyright "Copyright 2019, MyCompany"
#property link      "https://www.mycompany.com"
#property version   "1.00"
#property strict
input double StopLoss = 100.0;
input double TakeProfit = 200.0;
input double DipPercent = 5.0;
input int MagicNumber = 12345;
int OnInit()
{
    // Initialize the expert
    return(INIT_SUCCEEDED);
}
void OnTick()
{
    // Check if the bar has just opened
    if (TimeCurrent() == Time[0])
    {
        // Calculate the dip percentage
        double dip = (Low[1] - Low[2]) / Low[2] * 100;
        // Check if the current price is below the previous low by the dip percentage
        if (dip >= DipPercent)
        {
            // Check if there is already an open order with the Magic Number
            if (OrdersTotal() == 0 || OrdersTotal(MagicNumber) == 0)
            {
                // If it is, buy at market price
                OrderSend(Symbol(), OP_BUY, 1, Ask, 3, Ask - StopLoss * Point, Ask + TakeProfit * Point, "", MagicNumber);
            }
        }
        // Check if the stop loss or take profit levels have been reached
        for (int i = OrdersTotal() - 1; i >= 0; i--)
        {
            if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES))
            {
                if (OrderType() == OP_BUY && OrderMagicNumber() == MagicNumber)
                {
                    if (Bid <= OrderStopLoss() || Bid >= OrderTakeProfit())
                    {
                        OrderClose(OrderTicket(), OrderLots(), Bid, 3, CLR_NONE);
                    }
                }
            }
        }
    }
}

Quote

Disliked

Write all sentences what i need as list to write to you to brake down code and finally get all pieces of code Step by step

Quote

Disliked

Write the basic structure of the expert advisor, including the input parameters and the OnInit() and OnTick() functions

// Input parameters
input double dipLevel = 0.03; // Percentage of dip to buy
input double lots = 1.0; // Number of lots to buy
// OnInit function
void OnInit()
{
    // Initialization code goes here
}
// OnTick function
void OnTick()
{
    // Get the current price of the asset
    double currentPrice = Ask;
    // Check if the current price is at or below the dip level
    if (currentPrice <= dipLevel * iClose(NULL,0,1))
    {
        // Execute a buy order for the specified number of lots
        OrderSend(Symbol(), OP_BUY, lots, Ask, 3, Ask - dipLevel * Point, Ask + dipLevel * Point, "Buy the dips", 0, 0, Green);
    }
}

Quote

Disliked

write seperate functions for entry and exit logic in OnTick event - but without actual login in those functions - just to see skeleton of entire code

// OnTick function
void OnTick()
{
    EntryLogic();
    ExitLogic();
}
// Entry logic function
void EntryLogic()
{
    // Check if entry conditions are met
    // if (...)
    // {
    //  // Entry code goes here
    // }
}
// Exit logic function
void ExitLogic()
{
    // Check if exit conditions are met
    // if (...)
    // {
    //  // Exit code goes here
    // }
}

Quote

Disliked

add expert advisor input parameters stop loss, take profit, dip - all those parameters in percentige

// Input parameters
input double dipLevel = 0.03; // Percentage of dip to buy
input double stopLoss = 0.02; // Percentage of stop loss
input double takeProfit = 0.05; // Percentage of take profit
input double lots = 1.0; // Number of lots to buy
// OnInit function
void OnInit()
{
    // Initialization code goes here
}
// OnTick function
void OnTick()
{
    EntryLogic();
    ExitLogic();
}
// Entry logic function
void EntryLogic()
{
    // Check if entry conditions are met
    // if (...)
    // {
    //  // Entry code goes here
    // }
}
// Exit logic function
void ExitLogic()
{
    // Check if exit conditions are met
    // if (...)
    // {
    //  // Exit code goes here
    // }
}

Quote

Disliked

add sempty functions in OnTick event which checks is day and time allowed to trade and is the higher timeframe trend an uptrend - just to see skeleton of entire code

// OnTick function
void OnTick()
{
    // Check if current day and time is allowed for trading
    if (IsDayAndTimeAllowed())
    {
        // Check if higher timeframe trend is an uptrend
        if (IsHigherTimeframeTrendUptrend())
        {
            EntryLogic();
            ExitLogic();
        }
    }
}
// Function to check if current day and time is allowed for trading
bool IsDayAndTimeAllowed()
{
    // Day and time checking code goes here
    // return true or false
}
// Function to check if higher timeframe trend is an uptrend
bool IsHigherTimeframeTrendUptrend()
{
    // Higher timeframe trend checking code goes here
    // return true or false
}
// Entry logic function
void EntryLogic()
{
    // Check if entry conditions are met
    // if (...)
    // {
    //  // Entry code goes here
    // }
}
// Exit logic function
void ExitLogic()
{
    // Check if exit conditions are met
    // if (...)
    // {
    //  // Exit code goes here
    // }
}

Quote

Disliked

create logic for function IsDayAndTimeAllowed

bool CanTrade()
{
    // Get the current day of the week
    int dayOfWeek = DayOfWeek();
    // Get the current hour
    int hour = Hour();
    // Check if current day is allowed for trading
    if (dayOfWeek == 0 || dayOfWeek == 6)
    {
        return false; // Not allowed to trade on weekends
    }
    else
    {
        // Check if current time is allowed for trading
        if (hour < 8 || hour > 17)
        {
            return false; // Not allowed to trade outside of trading hours
        }
    }
    // Check if higher timeframe trend is an uptrend
    if(IsHigherTimeframeTrendUptrend())
    {
        return true;
    }
    return false;
}

Quote

Disliked

do not use IsHigherTimeframeTrendUptrend in function IsDayAndTimeAllowed and use IsDayAndTimeAllowed instead of CanTrade - date time must be sole logic and no other logic in that function inside - fix that and prepare again

bool IsDayAndTimeAllowed()
{
    // Get the current day of the week
    int dayOfWeek = DayOfWeek();
    // Get the current hour
    int hour = Hour();
    // Check if current day is allowed for trading
    if (dayOfWeek == 0 || dayOfWeek == 6)
    {
        return false; // Not allowed to trade on weekends
    }
    else
    {
        // Check if current time is allowed for trading
        if (hour < 8 || hour > 17)
        {
            return false; // Not allowed to trade outside of trading hours
        }
    }
    return true;
}

Quoting joyny

Disliked

{image} Installed "AI" app and started "teaching" it my personality. It helps me to findout answers on various topics. Idea is to talk regarding forex too. Maybe will give some interesting perspective. Wonder if it can be treated as real AI... Have you tried such apps? Will share here some topics from my "conversations" with AI regarding forex.

Ignored

Quoting clemmo17

Disliked

I have already used ChatGPT to 'fix' an indicator that wasn't compatible with newer versions of MT4, but when it comes to more specific code I find that it's very unreliable. Human expert intervention seems to be needed to fix bugs. Do you agree?

Ignored

Quoting clemmo17

Disliked

{quote} Oh man this is brilliant. I would love to turn the book club thread into a chatbot. How do I do it, Joyny?

Ignored

// Input parameters
input double dipLevel = 0.01; // the dip level in percentage
input int maxOrders = 1; // the maximum number of orders allowed
input double lots = 1; // the number of lots for each order
input int slippage = 3; // the maximum slippage allowed
input double stopLossPercentage = 0.03; // the stop loss level in percentage
input double takeProfitPercentage = 0.03; // the take profit level in percentage
// the take profit level in pips - added for safety reasons, the expert advisor will handle take profit and stop loss by itself, but this provides an additional layer of protection in case of unexpected events
input int takeProfitPips = 10; 
input int stopLossPips = 10; // the stop loss level in pips
input ENUM_TIMEFRAMES higherTimeframe = PERIOD_H1; // the higher timeframe for trend analysis
input bool allowedMonday = true;
input bool allowedTuesday = true;
input bool allowedWednesday = true;
input bool allowedThursday = true;
input bool allowedFriday = true;
input bool allowedSaturday = false;
input bool allowedSunday = false;
input int startTime = 1;
input int endTime = 23;
input int magicNumber = 12345;

// OnTick function
void OnTick()
{
    // Check if current day and time is allowed for trading
    if (IsDayAndTimeAllowed())
    {
        // Check if higher timeframe trend is an uptrend
        if (IsHigherTimeframeTrendUptrend())
        {
            EntryLogic();
            ExitLogic();
        }
    }
}
// Function to check if current day and time is allowed for trading
bool IsDayAndTimeAllowed()
{
    // Get the current date and time
    datetime currentTime = TimeCurrent();
    // Get the current day of the week
    int currentDay = DayOfWeek();
    // Get the current hour
    int currentHour = Hour();
    // Check if the current day is allowed
    if((currentDay == 1 && allowedMonday) || (currentDay == 2 && allowedTuesday) || (currentDay == 3 && allowedWednesday) || (currentDay == 4 && allowedThursday) || (currentDay == 5 && allowedFriday) || (currentDay == 6 && allowedSaturday) || (currentDay == 7 && allowedSunday))
    {
        // Check if the current hour is within the allowed range
        if(currentHour >= startTime && currentHour <= endTime)
        {
            return true;
        }
    }
    return false;
}
// Function to check if higher timeframe trend is an uptrend
bool IsHigherTimeframeTrendUptrend()
{
    // Get the current close price of the higher timeframe
    double currentClose = iClose(Symbol(), higherTimeframe, 0);
    // Get the previous close price of the higher timeframe
    double previousClose = iClose(Symbol(), higherTimeframe, 1);
    // Check if the current close price is greater than the previous close price
    if (currentClose > previousClose)
    {
        return true;
    }
    else
    {
        return false;
    }
}
// Entry logic function
void EntryLogic()
{
    // Get the current close price
    double currentClose = iClose(Symbol(), 0, 0);
    // Get the dip level
    double dip = dipLevel * currentClose;
    // check the current orders
    if (OrdersTotal() < maxOrders)
    {
        // Check if the current close price is below the dip level
        if (currentClose < dip)
        {
            // Check if the account balance and equity allow for the trade
            if(AccountBalance() > (lots * currentClose * stopLossPercentage) && AccountEquity() > (lots * currentClose * stopLossPercentage))
            {
                // Place a buy order
                int ticket = OrderSend(Symbol(), OP_BUY, lots, currentClose, slippage, currentClose + takeProfitPips * Point, currentClose - stopLossPips * Point, NULL, magicNumber,  0,  Green);
            }
        }
    }
}
// Exit logic function
void ExitLogic()
{
    for (int i = 0; i < OrdersTotal(); i++)
    {
        if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES) == false)
        {
            SendNotification("Failed to select order - OrderSelect() returned false");
            continue;
        }
        if (OrderSymbol() == Symbol() && OrderType() == OP_BUY)
        {
            double currentClose = iClose(Symbol(), 0, 0);
            double takeProfit = takeProfitPercentage * currentClose;
            double stopLoss = stopLossPercentage * currentClose;
            if (OrderProfit() >= takeProfit)
            {
                // Close the order with take profit
                if(OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), slippage) == false)
                   SendNotification("Failed to close order with take profit - OrderClose() returned false");
            }
            else if (OrderProfit() <= stopLoss)
            {
                // Close the order with stop loss
                if(OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), slippage) == false)
                   SendNotification("Failed to close order with stop loss - OrderClose() returned false");
            }
        }
    }
}

// Input parameters
input double dipLevel = 0.01; // the dip level in percentage
input int maxOrders = 1; // the maximum number of orders allowed
input double lots = 1; // the number of lots for each order
input int slippage = 3; // the maximum slippage allowed
input double stopLossPercentage = 0.03; // the stop loss level in percentage
input double takeProfitPercentage = 0.03; // the take profit level in percentage
input ENUM_TIMEFRAMES higherTimeframe = PERIOD_H1; // the higher timeframe for trend analysis
input int prevDays = 10;
input bool allowedMonday = true;
input bool allowedTuesday = true;
input bool allowedWednesday = true;
input bool allowedThursday = true;
input bool allowedFriday = true;
input bool allowedSaturday = false;
input bool allowedSunday = false;
input int startTime = 1;
input int endTime = 23;
input int magicNumber = 12345;

// OnTick function
void OnTick()
{
    // Check if current day and time is allowed for trading
    if (IsDayAndTimeAllowed() && IsHigherTimeframeTrendUptrend())
    {
        EntryLogic();
    }
    ExitLogic();
}

// Function to check if current day and time is allowed for trading
bool IsDayAndTimeAllowed()
{
    // Get the current date and time
    datetime currentTime = TimeCurrent();
    // Get the current day of the week
    int currentDay = DayOfWeek();
    // Get the current hour
    int currentHour = Hour();
    // Check if the current day is allowed
    if((currentDay == 1 && allowedMonday) || (currentDay == 2 && allowedTuesday) || (currentDay == 3 && allowedWednesday) || (currentDay == 4 && allowedThursday) || (currentDay == 5 && allowedFriday) || (currentDay == 6 && allowedSaturday) || (currentDay == 7 && allowedSunday))
    {
        // Check if the current hour is within the allowed range
        if(currentHour >= startTime && currentHour <= endTime)
        {
            return true;
        }
    }
    return false;
}
// Function to check if higher timeframe trend is an uptrend
bool IsHigherTimeframeTrendUptrend()
{
    // Get the current close price of the higher timeframe
    double currentClose = iClose(Symbol(), higherTimeframe, 0);
    // Get the previous close price of the higher timeframe
    double previousClose = iClose(Symbol(), higherTimeframe, 1);
    // Check if the current close price is greater than the previous close price
    if (currentClose > previousClose)
    {
        return true;
    }
    else
    {
        return false;
    }
}
// Entry logic function
void EntryLogic()
{
    // Get the previous high price for the past n days on D1 timeframe
    double prevHigh = iHigh(Symbol(), 1440, prevDays + 1);
    // Get the dip level
    double dip = prevHigh - (dipLevel * prevHigh);
    // check the current orders
    if (OrdersTotal() < maxOrders)
    {
        // Check if the current close price is below the dip level
        if (iClose(Symbol(), 1440, 1) < dip)
        {
            // Check if the account balance and equity allow for the trade
            if(AccountBalance() > (lots * iClose(Symbol(), 1440, 1) * stopLossPercentage) && AccountEquity() > (lots * iClose(Symbol(), 1440, 1) * stopLossPercentage))
            {
                // Place a buy order
                int ticket = OrderSend(Symbol(), OP_BUY, lots, Ask, slippage, 0, 0, NULL, magicNumber,  0,  Green);
                // Check if the order was successfully placed
                if(ticket > 0)
                {
                    Print("Order placed successfully. Ticket number: ", ticket);
                }
                else
                {
                    Print("Failed to place order. Error code: ", GetLastError());
                }
            }
        }
    }
}
// Exit logic function
void ExitLogic()
{
    for(int i = 0; i < OrdersTotal(); i++)
    {
        // Check if the order is a buy order and belongs to the current symbol
        if(OrderSelect(i, SELECT_BY_POS, MODE_TRADES) && OrderSymbol() == Symbol() && OrderType() == OP_BUY)
        {
            // Get the open price of the order
            double openPrice = OrderOpenPrice();
            // Calculate the stop loss level in pips
            double stopLoss = openPrice - (openPrice * stopLossPercentage / 100);
            // Calculate the take profit level in pips
            double takeProfit = openPrice + (openPrice * takeProfitPercentage / 100);
            // Check if the current price has reached the stop loss or take profit level
            if(iClose(Symbol(), 1440, 1) <= stopLoss || iClose(Symbol(), 1440, 1) >= takeProfit)
            {
                // Close the order
                if(OrderClose(OrderTicket(), OrderLots(), iClose(Symbol(), 1440, 1), slippage))
                {
                    Print("Order closed successfully. Ticket number: ", OrderTicket());
                }
                else
                {
                    Print("Failed to close order. Error code: ", GetLastError());
                }
            }
        }
    }
}