Error #130... what else right? | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

OrderModify error 130? 8 replies

Ordersend 'error 130' - problems 1 reply

error: 130:invalid stops 3 replies

Grid EA bug: missing orders due to invalid stops (error 130) 8 replies

Trailing stop has error 130 3 replies

Attachments: Error #130... what else right?
Exit Attachments

Error #130... what else right?

  • #1
  • First Post: Jan 23, 2010 4:27pm Jan 23, 2010 4:27pm
This seems like the bane of all OrderSend errors. I can't seem to figure out why the Stop loss price is not calculating properly. I've tried multiplying it by 10 etc but it always gives the same error and printout.

Error: EURGBP,M1: Enter Price: 0.74660000 Stop Loss: 0.74705000 Take Profit: 0.74600000


Inserted Code
void EnterTrade( double risk, int sl, int tp )
{
   RefreshRates();

   double SL, TP;
   int dollarsAtRisk = AccountEquity() * Risk;
   g_PositionSize = NormalizeDouble( (dollarsAtRisk / sl), 1 );
   
   if( g_ConfirmLong == true )
   {
      SL = Ask - (sl * Point);
      TP = Ask + (tp * Point);
      
      g_TradeID = OrderSend( Symbol(), OP_BUY, g_PositionSize, Ask, Slippage, NormalizeDouble( SL, Digits ), NormalizeDouble( TP, Digits ), TradeComment, 0, 0, Green );
      
      Print( "Enter Price: " + Ask + " Stop Loss: " + SL + " Take Profit: " + TP );
      
      if( g_TradeID < 0 )
      {
         Print( "OrderSend failed with error#", GetLastError() );
         ResetVars();
         return(0);
      }
sl and tp are passed by value integers of 45 and 60.
  • #2
  • Jan 23, 2010 5:33pm Jan 23, 2010 5:33pm
I may be wrong but, try to NormalizeDouble(Ask) for entry price as well.
  • #3
  • Jan 23, 2010 5:36pm Jan 23, 2010 5:36pm
we have to recreate your entire ea in our minds and then guess at what could be causing the problem when only a small part of the code is shown.....

my guess would be you have some sort a compainion function for the shorts....

maybe a g_ConfirmShort == true condition

and it has

g_TradeID = OrderSend( Symbol(), OP_BUY, g_PositionSize, Ask, Slippage, NormalizeDouble( SL, Digits ), NormalizeDouble( TP, Digits ), TradeComment, 0, 0, Green );

instead of OP_SELL.... but that's just a guess.....h
to trade and code, keep both simple... no call to impress....h
  • #4
  • Jan 23, 2010 6:16pm Jan 23, 2010 6:16pm
nah the else is this...

Inserted Code
   else
   {
      SL = Bid + (sl * Point);
      TP = Bid - (tp * Point);
   
      g_TradeID = OrderSend( Symbol(), OP_SELL, g_PositionSize, Bid, Slippage, NormalizeDouble( SL, 4 ), NormalizeDouble( TP, 4 ), TradeComment, 0, 0, Green );
      
      Print( "Enter Price: " + Bid + " Stop Loss: " + SL + " Take Profit: " + TP );
      
      if( g_TradeID < 0 )
      {
         Print( "OrderSend failed with error#", GetLastError() );
         ResetVars();
         return(0);
      }
  • #5
  • Jan 23, 2010 6:54pm Jan 23, 2010 6:54pm
both the buys and sells go thru for me, stoplosses and takeprofits are sent correctly..... had to modify a few things but nothing that would have resulted in correcting your error.....

without knowing more, it's difficult to trouble shoot......h
Attached File(s)
File Type: mq4 deced.mq4   2 KB | 533 downloads
to trade and code, keep both simple... no call to impress....h
  • #6
  • Jan 23, 2010 6:56pm Jan 23, 2010 6:56pm
What kind of info do you need?

This is happening for me in the Strategy Tester and I am using FXPro which is a 5 digit broker, is there anything else that would help?
  • #7
  • Jan 23, 2010 7:17pm Jan 23, 2010 7:17pm
just notice te sell had 4 instead of digits.... NormalizeDouble( SL, 4 ),

what is ResetVars(); doing.....h
to trade and code, keep both simple... no call to impress....h
  • #8
  • Jan 23, 2010 7:24pm Jan 23, 2010 7:24pm
Nothing really important, just resets the main loop to start looking for a new trade that meets my rules.

Inserted Code
void ResetVars()
{
   g_SignalLong      = false;
   g_SignalShort     = false;
   g_ConfirmLong     = false;
   g_ConfirmShort    = false;
   g_LookLong        = false;
   g_LookShort       = false;
   g_MonitoringTrade = false;
}
  • #9
  • Jan 23, 2010 7:28pm Jan 23, 2010 7:28pm
hey decidence..... the only way i can reproduce the error is by changing the OP_SELL to OP_BUY.... which reproduces it perfectly..... but that has been ruled out.....

one thing might help would be to change Enter Price to Buying Enter Price and Selling Enter Price so as to better distinguish between orders....h




Inserted Code
 
if( g_ConfirmLong == true )
   {
      SL = Ask - (sl * Point);
      TP = Ask + (tp * Point);
 
      g_TradeID = OrderSend( Symbol(), OP_BUY, 0.1, Ask, 3, NormalizeDouble( SL, Digits ), NormalizeDouble( TP, Digits ), 0, 0, 0, Green );
 
      Print( "Buying Enter Price: " + Ask + " Stop Loss: " + SL + " Take Profit: " + TP );
 
      if( g_TradeID < 0 )
      {
         Print( "OrderSend failed with error#", GetLastError() );
         //ResetVars();
         return(0);
      }
 
   }
 
     else
 
      {
      SL = Bid + (sl * Point);
      TP = Bid - (tp * Point);
 
      g_TradeID = OrderSend( Symbol(), OP_SELL, 0.1, Bid, 3, NormalizeDouble( SL, 4 ), NormalizeDouble( TP, 4 ), 0, 0, 0, Green );
 
 
      Print( "Selling Enter Price: " + Bid + " Stop Loss: " + SL + " Take Profit: " + TP );
 
 
      if( g_TradeID < 0 )
      {
         Print( "OrderSend failed with error#", GetLastError() );
         //ResetVars();
         return(0);
      }
    }
to trade and code, keep both simple... no call to impress....h
  • #10
  • Jan 23, 2010 7:38pm Jan 23, 2010 7:38pm
I changed the "4" in the sell order to "Digits" to match up with the buy order, and made that change you suggested. Still got the error though.

2010.01.23 17:37:27 2008.02.01 01:36 EURGBP,M1: Selling Enter Price: 0.74660000 Stop Loss: 0.74705000 Take Profit: 0.74600000


Its like it's doing the digit math wrong or something, since you can see it's setting the SL to 4.5 pips instead of 45 which is what's passed in to the function.
  • #11
  • Jan 23, 2010 7:52pm Jan 23, 2010 7:52pm
try changing 45 and 60 to 450 and 600..... perhaps the spread or mode_stoplevel are getting in the way..... increasing should rule those out......h
to trade and code, keep both simple... no call to impress....h
  • #12
  • Jan 23, 2010 8:06pm Jan 23, 2010 8:06pm
So I did this...

Inserted Code
      SL = Ask - (sl * 10 * Point);
      TP = Ask + (tp * 10 * Point);

and vice versa for sell orders, and that worked, yay! But it seems very unreliable depending on the broker someone might use my EA on.
  • #13
  • Jan 23, 2010 8:12pm Jan 23, 2010 8:12pm
no, change the 45 to 450 and 60 to 600.... where ever sl and tp are declared.... do not use (sl * 10 * Point); .....h
to trade and code, keep both simple... no call to impress....h
  • #14
  • Jan 24, 2010 2:27am Jan 24, 2010 2:27am
Thanks for all the help, time to start tweaking my settings for backtesting. Really sucks that the spreads are locked in at their highest levels over the weekend =(
  • #15
  • Jan 25, 2010 1:52am Jan 25, 2010 1:52am
decidence

The most probable cause for the error you are having is that your broker is an ECN / STP broker
When opening orders on ECN / STP broker you have to do it in 2 steps instead of the usual 1 :

1. open an order WITHOUT SL and/or TP
2. Modify the order opened that way by setting your SL and/or TP

  • #16
  • Jan 25, 2010 6:51am Jan 25, 2010 6:51am
Quoting mladen
decidence

The most probable cause for the error you are having is that your broker is an ECN / STP broker
When opening orders on ECN / STP broker you have to do it in 2 steps instead of the usual 1 :

1. open an order WITHOUT SL and/or TP
2. Modify the order opened that way by setting your SL and/or TP

no, the author wrote that it was FxPro, and that's a MM not ECn....

I guess that the problem is that you try to set the SL or TP too close to the Ask or Bid price.... especially that you deal with eurgbp.... there is usually given margin you have to respect + the spread....
  • #17
  • Apr 1, 2011 2:57pm Apr 1, 2011 2:57pm
The post about sending the order without stops and targets and then using OrderModify worked for me, thanks!

John
  • #18
  • Last Post: Apr 3, 2011 11:00am Apr 3, 2011 11:00am
That fixed my problem with executing trades in my demo account - but now my tester is giving 130 errors. Is there a consistent way to send the same set of trades to my demo account and allow me to test with that same EA?
0 traders viewing now