Please help me to get my Profit estimator working

Quoting enoeraew

Disliked

Hi, what I want is a quick way to estimate how much profit/loss I will have if I close all orders at a given level. I just can't seem to find the right math. I would appreciate any and all help with it. Thank you. {file}

Ignored

double profit(){
   double x=0;
   for(int i=OrdersTotal()-1;i>=0;i—)
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)x+=OrderProfit();
   return x;}

double profit(double price){
   double x=0;
   for(int i=OrdersTotal()-1;i>=0;i—)
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES){
         if(OrderType())x+=OrderOpenPrice()-price;
         if(OrderType()==0)x+=price-OrderOpenPrice();
         }
   return x;}

double profit(double price=NULL){
   double x=0;
   for(int i=OrdersTotal()-1;i>=0;i—)
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES){
         if(price==NULL){x+=OrderProfit();continue;}
         if(OrderType())x+=OrderOpenPrice()-price;
         if(OrderType()==0)x+=price-OrderOpenPrice();
      }
   return x;}

Quoting enoeraew

Disliked

Hi, thanks for your time. I'm a nub here, Could you just slap that code into my indicator. It will take me 3 hrs of trial and error to insert your solution myself. I really appreciate the lesson. Just so you know how incompetent I am i've been at this indi for 3 days copying and pasting the thing together from code i find online.. I am quite proud of what i did so far but also exhausted and frustrated, I really just need someone else to finish it for me at this point. thanks

Ignored

#property indicator_chart_window
#property strict
 int start(){
 
   double currProfit=profit();
   Comment("My current profit is: "+(string)currProfit);
   //or
   Comment("My current profit is: "+(string)profit());
   return 0;}
 
double profit(double price=NULL){
   double x=0;
   for(int i=OrdersTotal()-1;i>=0;i—)
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES){
         if(price==NULL){x+=OrderProfit();continue;}
         if(OrderType())x+=OrderOpenPrice()-price;
         if(OrderType()==0)x+=price-OrderOpenPrice();
         }
   return x;}

Quoting enoeraew

Disliked

here is what is in my code so far: #property copyright "" #property link "" #property version "1.00" #property strict #property indicator_chart_window double cprice, OpenPrice, pips, Size, Distance; static double EstimateLoss, EstimateGain ; //+------------------------------------------------------------------+ //| Custom indicator initialization function | //+------------------------------------------------------------------+ int OnInit() { //--- indicator buffers mapping double ticksize = MarketInfo(Symbol(),MODE_TICKSIZE); if (ticksize == 0.00001...

Ignored

#property strict
#property indicator_chart_window
#define closeLine "TotalCloseLine"
#define closeLabel "EstimateClose"
 
extern color p1=clrGreen;//Positive Profit Colour
extern color p2=clrRed;//Negative Profit Colour
extern color p3=clrGold;//Zero Profit Colour
enum _width{Zero,One,Two,Three,Four,Five};
extern _width width=2;//Line Width
 
void OnInit(){
   if(width>0)
      if(ObjectCreate(closeLine,OBJ_HLINE,0,0,Ask+(_Point*200))){
         ObjectSet(closeLine,OBJPROP_STYLE,STYLE_SOLID);
         ObjectSet(closeLine,OBJPROP_WIDTH,width);
         }
   if(ObjectCreate(closeLabel,OBJ_LABEL, 0,0,0)){
      ObjectSet(closeLabel,OBJPROP_CORNER,CORNER_RIGHT_LOWER);
      ObjectSet(closeLabel,OBJPROP_XDISTANCE,300);
      ObjectSet(closeLabel,OBJPROP_YDISTANCE,20);
      }
   EventSetMillisecondTimer(1);
   }
 
int OnCalculate(const int rates_total,const int prev_calculated,const datetime &time[],const double &open[],const double &high[],const double &low[],
              const double &close[],const long &tick_volume[],const long &volume[],const int &spread[]){main();return(rates_total);}
void OnTimer(){main();}
 
void OnDeinit(const int re){
   ObjectDelete(0,closeLine);
   ObjectDelete(0,closeLabel);
   }
 
void main(){
   long chart=ObjectFind(closeLine);
   double myProfit=chart>=0?profit(ObjectGetDouble(chart,closeLine,OBJPROP_PRICE)):profit();
   color colour=myProfit>0?p1:myProfit<0?p2:p3;
   ObjectSetText(closeLabel,"Estimated Profit $ "+DoubleToStr(myProfit,2),14,"Arial",colour);
   ObjectSet(closeLine,OBJPROP_COLOR,colour);
   }
 
double profit(double price=NULL){
  double x=0;
  for(int i=OrdersTotal()-1;i>=0;i--)
     if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
      if(OrderSymbol()==Symbol()){
        if(price==NULL){x+=OrderProfit();continue;}
        if(OrderType())x+=OrderOpenPrice()-price;
        if(OrderType()==0)x+=price-OrderOpenPrice();
        }
  return x;}

Quoting enoeraew

Disliked

BEERRUN! Thanks. I will sleep well now. Can't wait for the ticks to come in. I will have fun figuring out why it works.

Ignored

Quoting enoeraew

Disliked

Hi Beerrun, it looks to me that what you did calculated total pips. I wanted to get a dollar value so I made this change: if(OrderType()==1 && ( OrderOpenPrice() > price )) x+= ((OrderOpenPrice() -price) * OrderLots() * 10); if(OrderType()==1 && ( OrderOpenPrice() < price )) x-= ((price-OrderOpenPrice()) * OrderLots() * 10) ; if(OrderType()==0 && ( OrderOpenPrice() > price )) x-= ((OrderOpenPrice() -price) * OrderLots() * 10) ; if(OrderType()==0 && ( OrderOpenPrice() < price )) x+= ((price-OrderOpenPrice()) * OrderLots() * 10) ; That seemed to do...

Ignored

if(OrderType()==1&&(OrderOpenPrice()>price))x+=((OrderOpenPrice()-price)*OrderLots()*10);
if(OrderType()==1&&(OrderOpenPrice()<price))x-=((price-OrderOpenPrice())*OrderLots()*10);

if(OrderType())x+=(OrderOpenPrice()-price)*OrderLots()*10;

if(...)x-=(...)+OrderSwap();

double openPrice=OrderOpenPrice();
int type=OrderType();
if(type==1&&(openPrice>price))x+=(openPrice-price)*OrderLots()*10;
if(type==1&&(openPrice<price))x-=(price-openPrice)*OrderLots()*10;
x+=OrderSwap();

if(OrderType()==1)x+=((OrderOpenPrice()-price)*OrderLots()*10)+OrderSwap();

double profit(double _price=NULL,int _pips=10){
  double x=0;
  for(int i=OrdersTotal()-1;i>=0;i--)
     if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES))
      if(OrderSymbol()==Symbol()){
        if(_price!=NULL){
         int type=OrderType();
         if(type==1)x+=((OrderOpenPrice()-_price)*OrderLots()*_pips);
         if(type==0)x+=((_price-OrderOpenPrice())*OrderLots()*_pips);
         }
        else x+=OrderProfit();
        x+=OrderSwap();
        }
  return x;}

Quoting Ican2020

Disliked

Beerrun, you are not what you posted towards the last part of your last post. You are an amazing guy, a great friend of the community who is willing to help any time. So, don't ever use that word again

Ignored

Quoting enoeraew

Disliked

Hi Again BeerRun, Something is still not right with the indicator. Once swaps are introduced the thing goes off the rails. Let me say I don't mind that much, for what I need it for it is fine without including swaps. I just like to know why swaps seem to kill it. I made a little video so you can get an idea of what I mean. https://streamable.com/mxs9up Thank you

Ignored

Print(“X: “+(string)x+” /OrderSwap: “+(string)OrderSwap());
x+=OrderSwap();

Quoting enoeraew

Disliked

Hi Beerrun, So I think my monkey programming got it working. I moved the " /ticksize" part to the Profit() from the main() changed this ObjectSetText(closeLabel,"Estimated Profit $ "+DoubleToStr(myProfit/ticksize,2),14,"Arial",colour); to this ObjectSetText(closeLabel,"Estimated Profit $ "+DoubleToStr(myProfit,2),14,"Arial",colour); and the added this to the profit() if(type)x+=((OrderOpenPrice()-_price)*OrderLots()*_pips / ticksize); if(type==0)x+=((_price-OrderOpenPrice())*OrderLots()*_pips / ticksize); My brain can't comprehend the reasons why...

Ignored