EA31337 released for free | Page 4 | Forex Factory

Options

Go to
Permalinks
Print Thread

Similar Threads

No Free Lunch but all the Free Coffee you can drink 736 replies

SWAP free, rollover free Broker? 15 replies

Hi...best time to place order after news released 0 replies

Flyer! Version 2.00 is released. 0 replies

Cad News Released 1 Min Before... ! 43 replies

Attachments: EA31337 released for free
Exit Attachments

EA31337 released for free

  • #61
  • Edited 4:16pm Apr 21, 2018 10:21am | Edited 4:16pm
Quoting shiva
{quote} Hi Kenorb, I have all the files now (Hopefully) most other errors have disappeared but these remain. MA_Period_Fast' - variable already defined ea-input.mqh S_ALLIGATOR' - undeclared identifier EA31337.mq4 S_BANDS' - undeclared identifier EA31337.mq4
The 'variable already' is another problem how platform handles the includes. The compiler inclusion logic is bad designed and works differently on different versions, so I usually do #ifndef FILE_MQH, #define FILE_MQH, // main code here, #endif, to babysit the compiler flows, unless MQL is going to fix this properly. Check Chart.mqh file for the example.
Then S_BANDS is defined in ea-enums.mqh (check for v1.076 tag). In master branch, it's commented, as I did start some refactor, and it's not finished and it may take awhile, or not at all.
  • #63
  • Edited 10:51am Apr 22, 2018 9:40am | Edited 10:51am
Quoting kenorb
{quote} The 'variable already' is another problem how platform handles the includes. The compiler inclusion logic is bad designed and works differently on different versions, so I usually do #ifndef FILE_MQH, #define FILE_MQH, // main code here, #endif, to babysit the compiler flows, unless MQL is going to fix this properly. Check Chart.mqh file for the example. Then S_BANDS is defined in ea-enums.mqh...
Hi Kenorb,hope your weekend is going great. I have managed to eliminate most compile errors excepting the below. Any tip/hint will be useful.

'=' - structure have objects and cannot be copied Trade.mqh 56 18
  • #64
  • Apr 22, 2018 12:47pm Apr 22, 2018 12:47pm
Quoting shiva
{quote} Hi Kenorb,hope your weekend is going great. I have managed to eliminate most compile errors excepting the below. Any tip/hint will be useful. '=' - structure have objects and cannot be copied Trade.mqh 56 18
The line
trade_params = _params;

should be replaced with the line
trade_params.slippage = _params.slippage;
I am who I am
  • #65
  • Apr 22, 2018 6:36pm Apr 22, 2018 6:36pm
hey shiva im trying to load your settings with the EA on a eurusd chart and im getting the following error:

Attached Image (click to enlarge)
Click to Enlarge Name: ea error.jpg Size: 149 KB


anybody have any ideas?

thanks, blam


Quoting shiva
Hi Kenorb and everyone. Today's forward test on demo looks very encouraging. Results and set file attached. {file} {file} 50000 Demo account with 1:200 Leverage Number of trades: 99 Total lots traded: 150.16 Pips made: 354.8 Profit in $: 3579.24 A few cosmetic suggestions for the EA Order Comments Close all button Profit/Loss and Pip Counter
  • #66
  • Apr 22, 2018 10:57pm Apr 22, 2018 10:57pm
Quoting imwim
{quote} The line trade_params = _params; should be replaced with the line trade_params.slippage = _params.slippage;
Thanks. That did it
  • #67
  • Apr 22, 2018 10:59pm Apr 22, 2018 10:59pm
Quoting blamshakk
hey shiva im trying to load your settings with the EA on a eurusd chart and im getting the following error: {image} anybody have any ideas? thanks, blam {quote}
Hi blamshak, which version of EA are you using? I had used this
Attached File(s)
File Type: ex4 EA31337-Lite-v1.072.31.01.2017.ex4   808 KB | 676 downloads
  • #68
  • Apr 23, 2018 5:33am Apr 23, 2018 5:33am
Quoting shiva
{quote} Hi Kenorb,hope your weekend is going great. I have managed to eliminate most compile errors excepting the below. Any tip/hint will be useful. '=' - structure have objects and cannot be copied Trade.mqh 56 18
This is the platform bug. Re-read post #27 and #31.
  • #69
  • Edited 8:30am Apr 23, 2018 5:35am | Edited 8:30am
Quoting blamshakk
hey shiva im trying to load your settings with the EA on a eurusd chart and im getting the following error: {image} anybody have any ideas? thanks, blam {quote}
This is what it says it is. Your timeframes aren't active. Either you lack necessary data to perform your backtest (check your HST files) or it is related to a platform bug (so try on M15 or M30 instead as it may activate timeframes differently). This was also already mentioned in post #5 and post #7.
  • #70
  • Apr 23, 2018 5:40am Apr 23, 2018 5:40am
Quoting imwim
{quote} The line trade_params = _params; should be replaced with the line trade_params.slippage = _params.slippage;
This may break the code. What's broken, is the platform. If you upgrade to at least MetaEditor build 1745 it may just work as it is.
  • #71
  • Apr 23, 2018 5:42am Apr 23, 2018 5:42am
Quoting shiva
{quote} Hi blamshak, which version of EA are you using? I had used this {file}
Release files with the date got the expiration date, it may work, but only for the backtesting, not for the demo testing.
  • #72
  • Apr 23, 2018 6:46am Apr 23, 2018 6:46am
Quoting kenorb
{quote} This may break the code. What's broken, is the platform. If you upgrade to at least MetaEditor build 1745 it may just work as it is.
The latest MetaEditor build is 1601 while the latest MT4 build is 1090 both dated 19.05.2017 ...

MetaEditor build 1745 is not available yet, it should come with the MT4 build 1118 dated 20.04.2018 which some guys tell about it, but not yet available for MT4 community ...

Do you have a MT4 build later of build 1090 ?
I am who I am
  • #73
  • Edited 7:19am Apr 23, 2018 7:05am | Edited 7:19am
Quoting imwim
{quote} The latest MetaEditor build is 1601 while the latest MT4 build is 1090 both dated 19.05.2017 ... MetaEditor build 1745 is not available yet, it should come with the MT4 build 1118 dated 20.04.2018 which some guys tell about it, but not yet available for MT4 community ... Do you have a MT4 build later of build 1090 ?
Each broker got their own "latest" version (e.g. different version for Windows, Linux and macOS), which practically they got old buggy builds, because they're not updating it very often and MT4 is not much supported now (latest official MT4 installer removed from MQL CDN servers, and the brokers doesn't update their platforms often, or not at all). So you can either find the broker which got their "real" latest version, or just copy MetaEditor from the MT5, it's the same thing. I had ME build 1745 working with MT4 and compiled MQL4 code successfully.

$ wine filever metaeditor64.exe
--a-- W32 APP - 5.0.0.1755 shp 37,719,192 03-12-2018 metaeditor64.exe

For example, ME build 1755 should have been released on 18.01.2018 as far as I know.
  • #74
  • Apr 23, 2018 7:17am Apr 23, 2018 7:17am
??
Attached Image (click to enlarge)
Click to Enlarge Name: 2018-04-23 14_18_00-localhost_9877 - Remotedesktopverbindung.jpg Size: 62 KB
  • #75
  • Apr 23, 2018 7:54am Apr 23, 2018 7:54am
Quoting kenorb
{quote} ... just copy MetaEditor from the MT5, it's the same thing. I had ME build 1745 working with MT4 and compiled MQL4 code successfully. $ wine filever metaeditor64.exe --a-- W32 APP - 5.0.0.1755 shp 37,719,192 03-12-2018 metaeditor64.exe For example, ME build 1755 should have been released on 18.01.2018 as far as I know.
That's great, just done ...

Could you provide an image of back-testing result of the latest version EA31337 Lite v1.076 for the entire 2018, EUR/USD pair ?

My results is not good at all as the previous results you provided on the github ...
I am who I am
  • #76
  • Apr 23, 2018 8:00am Apr 23, 2018 8:00am
Quoting alexf82
?? {image}
This version has been expired, you need to download the 'Full' version (related: post #71).
  • #77
  • Edited 10:24am Apr 23, 2018 8:16am | Edited 10:24am
Quoting imwim
{quote} That's great, just done ... Could you provide an image of back-testing result of the latest version EA31337 Lite v1.076 for the entire 2018, EUR/USD pair? My results is not good at all as the previous results you provided on the GitHub ...
Recently I've lost the infrastructure which I was using for backtesting (german servers, AWS+Jenkins), so it'll take a while to do it again (as I was on holidays and bill didn't go through on-time). The latest EA version could have the latest fixes in place, but it doesn't mean it has been optimized as good as the previous ones, so it's a matter of testing it.

However, if you're on Linux/macOS, I've automated backtesting using scripts. So, using this repo, you can run like:

./scripts/run_backtest.sh -v -t -M4.0.0.1010 -d 10000 -p EURUSD -m 1-2 -y 2017 -s 10 -b DS -D5 -e EA31337

Where -m 1-2 is the range of months, or drop the -m param for the full year. The .ex4 you can place somewhere in the current dir.

See these CI builds for the example and expected behaviour.

If you're on Windows, you may consider Vagrant approach (see Vagrantfile, Docker support is on the way).

If you're on Linux/Unix/macOS, this should be straightforward. If you're testing this on Windows and struggling with setup, I won't be able to help much (unless you're doing this within VM after vagrant ssh command).

Note: One challenge which I got with backtesting recently was, that when running MT4 in off-line test by default platform is forcing the test with Lot step 0.1 for 5-digit symbols (which is wrong), where EA is more designed to run with Lot step 0.01 on 5-digit pairs, unless the balance is huge. Larger lot steps don't give EA much flexibility and not enough time learn about the market conditions, so backtesting with lot size of 0.1 isn't expected. The only workaround is to connect to one of the brokers which support micro lots (but at the same polluting the existing settings with the specific broker's settings), so I don't know how to enforce this Lot size manually (it requires a lot of hacks). So if you're lucky, when you run with 0.01 lot size, that's great, otherwise, the backtest could be not as expected.
  • #78
  • Apr 23, 2018 8:41am Apr 23, 2018 8:41am
Here is what i have

Will this spike is due to me closing all trades when i saw huge profit floating

Version 1.072 EURUSD 1M
Attached Image (click to enlarge)
Click to Enlarge Name: Screenshot1.png Size: 93 KB
  • #79
  • Apr 23, 2018 8:54am Apr 23, 2018 8:54am
Quoting abusaad412
Here is what i have Will this spike is due to me closing all trades when i saw huge profit floating Version 1.072 EURUSD 1M {image}
That's exactly I don't like it, different trade sizes 0.41 , 1.05 , which brings me an air of Martingale schema ...

I agree with entering multiple times with a fixed size to build an aggregated position ...

And not at the end, 10x to kenorb for the detailed guidance above ...
I am who I am
  • #80
  • Apr 23, 2018 8:56am Apr 23, 2018 8:56am
Quoting abusaad412
Here is what i have Will this spike is due to me closing all trades when i saw huge profit floating Version 1.072 EURUSD 1M {image}
I had reports that EA sometimes doesn't close huge profit on time (but it depends which version), so you did a good decision. Take profit is something that needs to be more optimized (but there is always dilemma like what-if you could get more). However, you may also setup the condition, to close the most profitable trades, once equity is above 10% or 20%
0 traders viewing now