I don't see trading FX as a profession as noble as medicine and others, but I don't see anything morally wrong with it. I mean, maybe traders don't produce anything usefull for the society - just "providing liquidity to the market", maybe - but ...