Attachments: ATR TM EA - Order Warnings / Guidance Appreciated

ATR TM EA - Order Warnings / Guidance Appreciated

#1
First Post: Dec 10, 2016 7:08am Dec 10, 2016 7:08am

plainkoi
| Joined Feb 2010 | Status: Trader | 12 Posts

Hello,

I would like to offer up and share my ATR TM (Trade Manager) EA, for some help in debugging the Order X commands and Path value returns.

Attached is the EA, ScottsPLDot Indicator and a screenshot of the Warning errors.

The EA uses ATR and risk percentage to calculate lot sizes for the pair based on dollar value, to get equal dollar value across all pairs and sets TP, SL, TS levels based on ATR for each pair. The ScottsPLDot Indicator is just used to visualize those TP, SL, TS levels. I do not use the lines as an indicator for entries. But to see if the TP targets are obtainable.

I manually enter trades on H4, D1 charts mostly, using PA, S/R lines, Volume and 8 EMA & 20 SMA, then let this EA manage the trades for me.

The EA maybe a little clunky coding wise, still an ameutor. While I was able to get my primary functions and calculations working, and the EA does function... I have always had a hard time with the Order X commands and control path processes. I would like to have a clean error free EA. I need to learn this, so I am hoping for guidance not neccessarily someone to just fix it. But if someone is feeling that generous... If you could explain what I coded incorrectly and why it needed to be another way, I would be grateful. Yes, I had spent a lot of time in the past with the MQL4 library... just never clicked in my brain.

I sincerely appreciate any guidance from the community.

Thank you.

Michael

P.S. Use at your own risk. I cannot currently gaurantee the values in the display are accurate as I have found some descrepencies on some pairs. Please note, EA only acts on first order. If scalling in, SL/TP value is applied to all orders as the first order. I did this on purpose to close out all orders when the market turned against me or when TP objective was hit. Plus it seemed to be the only way around FIFO.

Special thanks to Bubo who helped in my early education many years ago. And to the creator of the ScottsPLDot indicator.

Attached Image

Attached File(s)

ATR_TM.mq4 14 KB | 347 downloads

ScottsPLDot Indicator.ex4 7 KB | 363 downloads

#2
Dec 12, 2016 1:15pm Dec 12, 2016 1:15pm

arby1108
| Joined Dec 2016 | Status: Trader | 62 Posts

Here you have Without any Warnings...

Attached File(s)

ATR_TM.mq4 14 KB | 538 downloads

ATR_TM.ex4 19 KB | 410 downloads

#3
Dec 14, 2016 10:37am Dec 14, 2016 10:37am

plainkoi
| Joined Feb 2010 | Status: Trader | 12 Posts

Quoting arby1108

Disliked

Here you have Without any Warnings... {file} {file}

Ignored

Hello Arby,

Thank you for taking the time... If you have a few minutes... Could you explain my error? Perhaps what functions I should study up on?

I will review the code for side by side and see what I can learn about the changes.

Thanks again and have a great day!

Sincerely,

Michael

#4
Dec 14, 2016 2:35pm Dec 14, 2016 2:35pm

arby1108
| Joined Dec 2016 | Status: Trader | 62 Posts

ok

OrderSelect, OrderSend, OrderClose...... Are booleans, so if you put: OrderModify(ticket,OrderOpenPrice(),SL,TP,0,Yellow); you will get a Warning.

the correct way is:

bool xxxxx;
bool yyyyy;

xxxxx = OrderModify(ticket,OrderOpenPrice(),SL,TP,0,Yellow);
yyyyy = OrderSend(Symbol(),OP_SELL,tempLot,Bid,Slip,0,0,ma,Magic,0,Red);
and so on.

#5
Dec 14, 2016 5:19pm Dec 14, 2016 5:19pm

plainkoi
| Joined Feb 2010 | Status: Trader | 12 Posts

Thank you for clearing that up. Something so obvious... *sigh*

Learning something new everyday. : ) Thanks again for your time.

#6
Edited 10:23am Dec 29, 2016 6:56am | Edited 10:23am

plainkoi
| Joined Feb 2010 | Status: Trader | 12 Posts

Hello All,

I think I cleaned up a bug in the lot size calculations. But not what this post is about.

I am attempting to make the EA leaner, loaded on all pairs, my platform spikes and stays at about 1GB of RAM usuage and pegs the CPU.

Attached Image

I have tried limiting to update only on a new candle using:

Inserted Code

       if    (iTime(Symbol(),0,1)!= Prior_TF_Bar_Time)
                       {
                        Prior_TF_Bar_Time = iTime(Symbol(),0,1);
 
                        //Various calculations and functions etc...
 
                        }

Which works, but then the values in the display flash off, until the next candle or change in TF. Does anyone have any suggestions about how I can either:

A. Keep the values in the display from disappearing? Maybe buffer the values so they are not updating with each Tick?
or
B. Another way I can make the EA leaner and lighter?

Attached Image

Using Comment to create display.

Inserted Code

  {
         Comment
         ("\n",
         "\n",
         "\n",
         "\n","                      ======== ATR Trade Manager EA  ========",
         "\n",
         "\n","                       ATR Period: " + ATRPeriod + "    ATR TF: " + Primary_TF + "    ATR: " + DoubleToStr(ATRV,2) + " Pips",
         "\n",
         "\n","                       Position Risk: " + DoubleToStr(RiskPercent,1) +  "%                    Volume Size: " + DoubleToStr(Lot,2),
         "\n",   
         "\n","                       Nominal Pip Value (1.00): $" + DoubleToStr(NominalPipValue,2) + "  Pip Value: $" +  DoubleToStr(PipValue,2),
         "\n",
         "\n","                       ATR Stop Loss     :   " + DoubleToStr(ATRSL,1) + " Pips   ", "    SL : $   - " + DoubleToStr(FullSL,2),
         "\n","                       ATR Trailing Stop :  " + DoubleToStr(ATRTS,1) + " Pips  ",
         "\n","                       ATR Take Profit   :  " + DoubleToStr(ATRTP,1) + " Pips  ", "     TP : $ + " + DoubleToStr(FullTP,2),
         "\n",
         "\n","                       Pair Floating Pips : " +  DoubleToStr(Fl_Pip,1) + "        Floating P/L : $  " + DoubleToStr(Sum_Profit,2),
         "\n",
         "\n","                       Minimum Scale In Intervals : " + DoubleToStr((ATRV/Scale_In_Intervals),2),
         "\n",
         "\n","                       Total Order Open Lots : " +  DoubleToStr(lots_total,2),
         "\n","                       ===============================");
         }

Thank you very much for your feedback and have a great day! : )

Attached File(s)

ATR_TM.mq4 15 KB | 477 downloads

P.S. No promises on the bug fix for the lot sizing and pip value calculations for those odd pairs. Still need to cross check with a calculator. Use at your own risk.

#7
Last Post: Edited 7:15pm Jul 22, 2017 7:02pm | Edited 7:15pm

irvanhidan
| Joined Jun 2016 | Status: Target 2%/Month or 20%/Year | 101 Posts

Quoting plainkoi

Disliked

Hello All, I think I cleaned up a bug in the lot size calculations. But not what this post is about. I am attempting to make the EA leaner, loaded on all pairs, my platform spikes and stays at about 1GB of RAM usuage and pegs the CPU. {image} I have tried limiting to update only on a new candle using: if (iTime(Symbol(),0,1)!= Prior_TF_Bar_Time) { Prior_TF_Bar_Time = iTime(Symbol(),0,1); //Various calculations and functions etc... } Which works, but then the values in the display flash off, until the next candle or change in TF. Does anyone have...

Ignored

hello plankoi thank you for the EA , can you add limit order to ea based distance ATR mulltiplier and callculated all posisition for same sl so all lot size auto increment because sl is more close ?i need that for ME/ME Trade.thank you

2% target/Month !

Platform Tech
/
ATR TM EA - Order Warnings / Guidance Appreciated
Reply to Thread

0 traders viewing now

Options

Similar Threads

ATR TM EA - Order Warnings / Guidance Appreciated