Bug Alert? Please help | Forex Factory

Options

Permalinks
Print Thread

Similar Threads

Please help me with an alert bug 5 replies

Bug in simple code, please help to pinpoint 8 replies

Please add email alert to this price alert indicator 0 replies

Please add alert to Parabolic Sar 2TF - Please Help! 0 replies

Can't find eachtickmode bug, please help 3 replies

Attachments: Bug Alert? Please help
Exit Attachments

Bug Alert? Please help

  • #1
  • First Post: Apr 29, 2014 9:04am Apr 29, 2014 9:04am
Hi guys.

I am working whole day on this but can't find why I am getting nonstop alert and also both alert at ones
I really can't find what the f... is going on because there are two main different if's conditions but code is triggering both together....
Any help will be great guys!!

THX

Inserted Code
extern string symbol1  = "EURUSDm";
extern string symbol2  = "EURAUDm";
extern string symbol3  = "EURJPYm";
extern string symbol4  = "EURGBPm";
extern string symbol5  = "GBPUSDm";
int LastAlert = 3;
//+------------------------------------------------------------------+
int start()
{
if((iVolume(symbol1, mTF, 1) < (iVolume(symbol1, mTF, iLowest(symbol1, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol1, mTF, 1) > iOpen(symbol1, mTF, 1)))   {mPair1Bear = 1; symbol11Bear = symbol1;}
   {
   if((iVolume(symbol2, mTF, 1) < (iVolume(symbol2, mTF, iLowest(symbol2, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol2, mTF, 1) > iOpen(symbol2, mTF, 1))) {mPair2Bear = 1; symbol22Bear = symbol2;}
   if((iVolume(symbol3, mTF, 1) < (iVolume(symbol3, mTF, iLowest(symbol3, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol3, mTF, 1) > iOpen(symbol3, mTF, 1))) {mPair3Bear = 1; symbol33Bear = symbol3;}
   if((iVolume(symbol4, mTF, 1) < (iVolume(symbol4, mTF, iLowest(symbol4, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol4, mTF, 1) > iOpen(symbol4, mTF, 1))) {mPair4Bear = 1; symbol44Bear = symbol4;}
   if((iVolume(symbol5, mTF, 1) < (iVolume(symbol5, mTF, iLowest(symbol5, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol5, mTF, 1) > iOpen(symbol5, mTF, 1))) {mPair5Bear = 1; symbol55Bear = symbol5;}
   {
   if((mPair1Bear + mPair2Bear + mPair3Bear + mPair4Bear + mPair5Bear) >=2)
               {
               if(LastAlert != 1)
            {
               LastAlert = 1;
               mStoredMinVolumeTimeBear = iTime(NULL, mTF, 1);
               DrawLine(Red, mStoredMinVolumeTimeBear);
               Alert(Symbol() + Period() + "M" + " LowVoluem candle bearish on Pairs = " + symbol22Bear + symbol33Bear + symbol44Bear + symbol55Bear);
            }
               }
   }
   }                                    
if((iVolume(symbol1, mTF, 1) < (iVolume(symbol1, mTF, iLowest(symbol1, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol1, mTF, 1) < iOpen(symbol1, mTF, 1))) {mPair1Bull = 1; symbol1Bull = symbol1;}
   {
   if((iVolume(symbol2, mTF, 1) < (iVolume(symbol2, mTF, iLowest(symbol2, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol2, mTF, 1) < iOpen(symbol2, mTF, 1))) {mPair2Bull = 1; symbol22Bull = symbol2;}
   if((iVolume(symbol3, mTF, 1) < (iVolume(symbol3, mTF, iLowest(symbol3, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol3, mTF, 1) < iOpen(symbol3, mTF, 1))) {mPair3Bull = 1; symbol33Bull = symbol3;}
   if((iVolume(symbol4, mTF, 1) < (iVolume(symbol4, mTF, iLowest(symbol4, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol4, mTF, 1) < iOpen(symbol4, mTF, 1))) {mPair4Bull = 1; symbol44Bull = symbol4;}
   if((iVolume(symbol5, mTF, 1) < (iVolume(symbol5, mTF, iLowest(symbol5, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol5, mTF, 1) < iOpen(symbol5, mTF, 1))) {mPair5Bull = 1; symbol55Bull = symbol5;}
   {
   if((mPair1Bull + mPair2Bull + mPair3Bull + mPair4Bull + mPair5Bull) >=2)
               {
               if(LastAlert != 2)
            {
               LastAlert = 2;                 
               mStoredMinVolumeTimeBull = iTime(NULL, mTF, 1);
               DrawLine(Lime, mStoredMinVolumeTimeBull);
               Alert(Symbol() + Period() + "M" + " LowVoluem candle bullish on Pairs = " + symbol22Bull + symbol33Bull + symbol44Bull + symbol55Bull);
            }
               }
   }
   }               
          
      return(0);
      
}
Attached Image (click to enlarge)
Click to Enlarge Name: alert bug.JPG Size: 84 KB
  • #2
  • Apr 29, 2014 10:08am Apr 29, 2014 10:08am
One thing that may help is to format the code better, which will make it easier to to follow the flow and structure of the program. It will also make others more inclined to help you, as they can grok the code much easier.

https://en.wikipedia.org/wiki/Indent_style
Quote
Indentation is not a requirement of most programming languages, where it is used as secondary notation. Rather, programmers indent to better convey the structure of their programs to human readers. In particular, indentation is used to show the relationship between control flow constructs such as conditions or loops and code contained within and outside them.
  • #3
  • Apr 29, 2014 10:38am Apr 29, 2014 10:38am
I am attaching whole code with also info what each line is doing.
Again thanks for any help. Because I am not lost. Can;t find why it is not working
Attached Image (click to enlarge)
Click to Enlarge Name: ALERT BUG1.JPG Size: 245 KB
Attached File(s)
File Type: mq4 mVolume NSND with MA direction with Bull Bear NEw Coding style Repairing.mq4   9 KB | 281 downloads
  • #4
  • Apr 29, 2014 8:08pm Apr 29, 2014 8:08pm
You might find that your if statements need to be reset before each new test of a condition. The way your code is at present, old values are retained and so will be brought into any new alert, giving false alerts.

suggest you add:
mPair1Bear = 0; (plus a simlar statement for each variable)
at the beginning of the start routine.

cheers
Fred
" check out The Traders Outpost "
  • #5
  • Apr 30, 2014 12:18am Apr 30, 2014 12:18am
Quoting RedLineFred
You might find that your if statements need to be reset before each new test of a condition. The way your code is at present, old values are retained and so will be brought into any new alert, giving false alerts. suggest you add: mPair1Bear = 0; (plus a simlar statement for each variable) at the beginning of the start routine. cheers Fred

something like this?

Inserted Code
int start()
{
mPair1Bear = 0; mPair2Bear = 0; mPair3Bear = 0; mPair4Bear = 0; mPair5Bear = 0;
if((iVolume(symbol1, mTF, 1) < (iVolume(symbol1, mTF, iLowest(symbol1, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol1, mTF, 1) > iOpen(symbol1, mTF, 1)))
  {mPair1Bear = 1;  symbol11Bear = symbol1;}
   {
   if((iVolume(symbol2, mTF, 1) < (iVolume(symbol2, mTF, iLowest(symbol2, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol2, mTF, 1) > iOpen(symbol2, mTF, 1))) {mPair2Bear = 1; symbol22Bear = symbol2;}
   if((iVolume(symbol3, mTF, 1) < (iVolume(symbol3, mTF, iLowest(symbol3, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol3, mTF, 1) > iOpen(symbol3, mTF, 1))) {mPair3Bear = 1; symbol33Bear = symbol3;}
   if((iVolume(symbol4, mTF, 1) < (iVolume(symbol4, mTF, iLowest(symbol4, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol4, mTF, 1) > iOpen(symbol4, mTF, 1))) {mPair4Bear = 1; symbol44Bear = symbol4;}
   if((iVolume(symbol5, mTF, 1) < (iVolume(symbol5, mTF, iLowest(symbol5, mTF, MODE_VOLUME, 4, 2)))) && (iClose(symbol5, mTF, 1) > iOpen(symbol5, mTF, 1))) {mPair5Bear = 1; symbol55Bear = symbol5;}
   {
   if((mPair1Bear + mPair2Bear + mPair3Bear + mPair4Bear + mPair5Bear) >=2)
  • #6
  • Last Post: Apr 30, 2014 5:30am Apr 30, 2014 5:30am
yes but don't forget to do all the variables, including the mPairxxxBulls also
" check out The Traders Outpost "
0 traders viewing now