closing order

pls help, the EA im working on opens and close trade every tick

1st, it opens order fulfilling the conditions, but 1-2 ticks, it closes trade. using on m15, having the same signals, it will again open a trade and closes again 1-2 ticks.

please help.

here is the closing code:

if(iOpen(NULL,0,0) < t3clean10 && CalcTotalOrders()>0)Close_Buy_Trade();
if(iOpen(NULL,0,0) > t3clean10 && CalcTotalOrders()>0)Close_Sell_Trade();


//+------------------------------------------------------------------+

int CalcTotalOrders()
{
int TotalOrders=0;
for (int pos=0; pos<OrdersTotal(); pos++) {
if (OrderSelect(pos, SELECT_BY_POS, MODE_TRADES)){
if (OrderMagicNumber()==Magic&&OrderSymbol()==Symbol())TotalOrders++;
}
}
return (TotalOrders);
}
//+------------------------------------------------------------------+

void Close_Sell_Trade()
{
for (int i=0; i<OrdersTotal(); i++){
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)){
if (OrderMagicNumber()==Magic&&OrderSymbol()==Symbol()){
if (OrderType()==OP_SELL){
bool sell_close=OrderClose(OrderTicket(),OrderLots(),Ask,Slippage,Red);
}
}
}
}
}

//+------------------------------------------------------------------+

void Close_Buy_Trade()
{
for (int i=0; i<OrdersTotal(); i++){
if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)){
if (OrderMagicNumber()==Magic&&OrderSymbol()==Symbol()){
if (OrderType()==OP_BUY){
bool buy_close=OrderClose(OrderTicket(),OrderLots(),Bid,Slippage,Red);
}
}
}
}
}
//+-----------------------------------------------------------------+

also, how can i close a trade when the bar close is below or above t3clean10 value?

I think what you saying is the EA opens a trade upon price crossing the t3Clean10 value and closes the same order if it crosses in the opposite direction. If I have got that wrong, please ignore the rest.

This is essentially the same problem people have when they set an alarm to be triggered when the price crosses a calculated value and it gets triggered multiple times. The reason is very simple - each new tick changes the calcuated value (some call it repainting).

The solution is make the second crossing less sensitive than the first. So the second crossing could be delayed until it happens on the next bar which may not be optimal. Or a built in tolerance of say 15 pips could be used. In other words, the second crossing would be ignored unless the price has moved 15 pips in either direction since the first crossing.

actually, it opens a trade fulfilling the conditions.

ta3clean10 is just only one condition to open. the opening is ok.

my problem is i want the trade to close as soon as the price is below or above the ta3clean10 value.

i actually want it to be every tick. but testing it shows that it is not closing right since 10pips below ta3clean10, still the trade is not closed.

Let me see if I understand what you want:
If you have a buy and current price is below ta3clean1, then you want to close the buy_trade.
In your code you have this condition to close a trade:
iOpen(Null, 0, 0) gives the openprice for the current bar at the current timeframe for the currency pair that the EA is placed on. This means that only when the openprice is below t3clean10 the trade will close. If you want to close the trade when current price is below t3clean10you need to use Bid.
------------------------------------------------------------- Use this code to get the close price of the previous bar (change the 1 to 0 if you want the close price of the current bar, but that would be the same as Bid):
You might want to check this out.