• Home
  • Forums
  • Trades
  • News
  • Calendar
  • Market
  • Brokers
  • Login
  • Join
  • User/Email: Password:
  • 2:46am
Menu
  • Forums
  • Trades
  • News
  • Calendar
  • Market
  • Brokers
  • Login
  • Join
  • 2:46am
Sister Sites
  • Metals Mine
  • Energy EXCH
  • Crypto Craft

Options

Bookmark Thread

First Page First Unread Last Page Last Post

Print Thread

Similar Threads

Daily Highs and Lows to Previous Daily Highs and Lows 1 reply

Higher Highs/ Lows and Lower Highs/ Lows 14 replies

buying and selling the news, eurusd 29/4/08 1 reply

Difference between selling a Call and buying a Put? 5 replies

Buying Dips and Selling Rallies 16 replies

  • Trading Systems
  • /
  • Reply to Thread
  • Subscribe
  • 38
Attachments: The Ghillyoar System (buying highs and selling lows)
Exit Attachments

The Ghillyoar System (buying highs and selling lows)

  • Last Post
  •  
  • 1 45Page 678 10
  • 1 5Page 67 10
  •  
  • Post #101
  • Quote
  • Apr 23, 2021 8:39am Apr 23, 2021 8:39am
  •  danjuma
  • | Joined Feb 2010 | Status: Member | 560 Posts
Quoting fxtrue
Disliked
As promised, I attach Paddy9's (moderately) cleaned-up code for the Ghilly Oar system that generated the provided test results. Paddy9 explained that the purpose of this thread was to encourage some "thinkers" (rather than "takers") get involved and try adding additional exit rules that might benefit the system and be adopted if useful. You will therefore find example code at lines 600-602 than can be copied and used to add additional rules. I hope that useful rules will be shared ...just as I hope that the source code of other EAs for this strategy...
Ignored
Hi fxtrue, firstly thanks for the attached EA. Just an observation, I think the EA, in terms of pips calculation etc. does not appear to work accurately with Yen pairs. When it is attached to say USDJYP, the sell bench or buy bench instead of being 30 pips away from the close of the candle 2, does not appear to be the case.
 
 
  • Post #102
  • Quote
  • Apr 23, 2021 9:10am Apr 23, 2021 9:10am
  •  SWGamer
  • | Joined Jan 2021 | Status: Member | 20 Posts
Quoting fxtrue
Disliked
As promised, I attach Paddy9's (moderately) cleaned-up code for the Ghilly Oar system that generated the provided test results. Paddy9 explained that the purpose of this thread was to encourage some "thinkers" (rather than "takers") get involved and try adding additional exit rules that might benefit the system and be adopted if useful. You will therefore find example code at lines 600-602 than can be copied and used to add additional rules. I hope that useful rules will be shared ...just as I hope that the source code of other EAs for this strategy...
Ignored
Thanks for uploading for us.
 
 
  • Post #103
  • Quote
  • Edited at 12:29pm Apr 24, 2021 9:58am | Edited at 12:29pm
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
In the image attached we have a case where we open much more sell trades than buy trades.

So exit rule #2 won't apply and we are in danger, i suggest to try to cut loss if we have the double of open trade in one direction.

Let say for example : 2 buy, 4 sell, close all open order
Attached Image (click to enlarge)
Click to Enlarge

Name: Capture decran 2021-04-24 a 15.53.33.png
Size: 95 KB
 
 
  • Post #104
  • Quote
  • Apr 24, 2021 5:45pm Apr 24, 2021 5:45pm
  •  tesiag
  • | Joined Apr 2021 | Status: Member | 68 Posts
Quoting neosqualls
Disliked
In the image attached we have a case where we open much more sell trades than buy trades. So exit rule #2 won't apply and we are in danger, i suggest to try to cut loss if we have the double of open trade in one direction. Let say for example : 2 buy, 4 sell, close all open order {image}
Ignored
Really strange behaviour....also order 107 has a profit of 20 in 10 pips with a size of 0.24.
You seem to have changed parameters in lot side, profit target for rule#1 and maybe (what could explain your results) also the profit exit in rule#2
 
 
  • Post #105
  • Quote
  • Apr 25, 2021 9:41am Apr 25, 2021 9:41am
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Quoting tesiag
Disliked
{quote} Really strange behaviour....also order 107 has a profit of 20 in 10 pips with a size of 0.24. You seem to have changed parameters in lot side, profit target for rule#1 and maybe (what could explain your results) also the profit exit in rule#2
Ignored
No, i didn't change lot size, only played with "TargetStep" & "ExitProfit".

No order 107 on my screenchot.
 
 
  • Post #106
  • Quote
  • Apr 26, 2021 6:06am Apr 26, 2021 6:06am
  •  Paddy9
  • Joined Jul 2008 | Status: Member | 232 Posts
eurusd Sept 2013 to 23.3.21
Attached Image (click to enlarge)
Click to Enlarge

Name: Ghillyoar with slightly adjusted settings.gif
Size: 12 KB
 
 
  • Post #107
  • Quote
  • Apr 26, 2021 12:08pm Apr 26, 2021 12:08pm
  •  JoanGuz
  • | Joined May 2020 | Status: Member | 15 Posts
Hi!

I just read the whole thread and want to thank Paddy9 for sharing the system, the rules and the code! And fxtrue for cleaning and posting the EA.

I downloaded and quick test the EA and looks promising and from my humble point of view, has a lot of potential.

I'll be working on it to improve it and share here any idea that enhance the results. Right now I want to understand it 100% before tweaking it. But, I agree that the main focus should be reducing the big loss trades without reducing the overall profitability of the system.

Paddy9 please don't leave so soon your thread, you sparked interest in the matter and I believe that even if just a few traders works on it and share the results, the system could be better for all of us.

Thanks again!!
 
 
  • Post #108
  • Quote
  • Apr 26, 2021 12:56pm Apr 26, 2021 12:56pm
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Quoting Paddy9
Disliked
eurusd Sept 2013 to 23.3.21 {image}
Ignored
Not easy to tell from the screenshot but i feel like ExitProfit & TargetStep are dynamic. I will try to add normal distribution to set ExitProfit & TargetStep maybe it can give good results. If then i will put it on real account to forward test.
 
 
  • Post #109
  • Quote
  • Apr 27, 2021 10:26am Apr 27, 2021 10:26am
  •  tesiag
  • | Joined Apr 2021 | Status: Member | 68 Posts
Hi all,
no news from backtests?

paddy9 asked for suggestions of new exit rules to replace (or to add to) rule#2 of the system. At the moment I'm not able to propose any "reasoned" alternative to rule#2.
On the other hand, I would propose some kind of "modification" to the update of the Buy bench and sell bench which sometimes get very far apart (typically when the the first entry is just after a parabolic growth/drop which makes the entry price quite distant from the moving average). A condition to reduce the gap between buy and sell benches when they exceed some given (or computed) value could be implemented to see whether this brings some improvement or not.

Any thought on this?
 
 
  • Post #110
  • Quote
  • Apr 27, 2021 11:04am Apr 27, 2021 11:04am
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Quoting tesiag
Disliked
Hi all, no news from backtests? paddy9 asked for suggestions of new exit rules to replace (or to add to) rule#2 of the system. At the moment I'm not able to propose any "reasoned" alternative to rule#2. On the other hand, I would propose some kind of "modification" to the update of the Buy bench and sell bench which sometimes get very far apart (typically when the the first entry is just after a parabolic growth/drop which makes the entry price quite distant from the moving average). A condition to reduce the gap between buy and sell benches when...
Ignored
The use of dynamic ExitProfit and TargetStep is not the way to go. Backtesting is a long process ...
 
 
  • Post #111
  • Quote
  • Apr 27, 2021 11:20am Apr 27, 2021 11:20am
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Here are some parameters i will focus on for the next backtesting :

Inserted Code
      double Target1                    = 0;
      double Highest_Ever_Funds         = 0;
      double Buy_Bench                  = 0;
      double Sell_Bench                 = 10001;
      int    NextOpenTradeAfterDays     = 1; //next open trade after time
      int    MaxSlippage                = 3; //adjusted in OnInit
      int    MaxOpenTrades              = 1000;
      int    MaxLongTrades              = 1000;
      int    MaxShortTrades             = 1000;
 
 
  • Post #112
  • Quote
  • Apr 27, 2021 11:53am Apr 27, 2021 11:53am
  •  tesiag
  • | Joined Apr 2021 | Status: Member | 68 Posts
Quoting neosqualls
Disliked
Here are some parameters i will focus on for the next backtesting : double Target1 = 0; double Highest_Ever_Funds = 0; double Buy_Bench = 0; double Sell_Bench = 10001; int NextOpenTradeAfterDays = 1; //next open trade after time int MaxSlippage = 3; //adjusted in OnInit int MaxOpenTrades = 1000; int MaxLongTrades = 1000; int MaxShortTrades = 1000;
Ignored
Those are inner variables used by the EA code. You need to focus on the input parameters (those defined by the keyword "input").
 
 
  • Post #113
  • Quote
  • Apr 27, 2021 12:01pm Apr 27, 2021 12:01pm
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Quoting tesiag
Disliked
{quote} Those are inner variables used by the EA code. You need to focus on the input parameters (those defined by the keyword "input").
Ignored
I disagree, there is interesting parameters like the "NextOpenTradeAfterDays" or the number of max open trades. If you only focus only changing ExitProfit && TargetStep are you not just doing over optimization for a specific period which obviously can be different in the future ?
 
 
  • Post #114
  • Quote
  • Apr 27, 2021 12:18pm Apr 27, 2021 12:18pm
  •  neosqualls
  • | Joined Feb 2011 | Status: Member | 137 Posts
Here is a backtest using default parameters but same period as Paddy's last post. I have around 3 times less of trades.
Attached Image (click to enlarge)
Click to Enlarge

Name: 678b22506b2a25adf9a1ccd37b75b2ae.png
Size: 60 KB
 
 
  • Post #115
  • Quote
  • Apr 28, 2021 12:35pm Apr 28, 2021 12:35pm
  •  danjuma
  • | Joined Feb 2010 | Status: Member | 560 Posts
Something that baffles me! Did a quick backtest using MT4 strategy tester (I know it's not completely reliable) using the following settings (Tradesize=0.05, ExitProfit=20, TargetStep=50, MaMethod=1) on USD5000 starting balance, on GBPUSD, USDCAD and EURUSD between 01/12/2019 to 10/03/2021. GBPUSD and USDCAD returned decent profits with decent max drawdown, but EURUSD returned a massive loss with big drawdown. What gives!

GBPUSD: net profit = 1405.10 Max DD = 952.34 (18.16%)
USDCAD: net profit = 719.39 Max DD = 803.48 (14.05%)
EURUSD: net profit = -3550.66 Max DD = 3934.48 (77.60%)
 
 
  • Post #116
  • Quote
  • Apr 28, 2021 12:47pm Apr 28, 2021 12:47pm
  •  srt56
  • | Joined Jan 2020 | Status: Member | 10 Posts
Hello
If there are dependencies, for example, on a currency pair, timeframe, time, news, etc., then this is not an algorithm, but just a coincidence.
Best wishes in mastering ...
 
2
  • Post #117
  • Quote
  • Apr 28, 2021 12:58pm Apr 28, 2021 12:58pm
  •  mtako
  • Joined Sep 2020 | Status: Member | 3,124 Posts
Quoting danjuma
Disliked
Something that baffles me! Did a quick backtest using MT4 strategy tester (I know it's not completely reliable) using the following settings (Tradesize=0.05, ExitProfit=20, TargetStep=50, MaMethod=1) on USD5000 starting balance, on GBPUSD, USDCAD and EURUSD between 01/12/2019 to 10/03/2021. GBPUSD and USDCAD returned decent profits with decent max drawdown, but EURUSD returned a massive loss with big drawdown. What gives! GBPUSD: net profit = 1405.10 Max DD = 952.34 (18.16%) USDCAD: net profit = 719.39 Max DD = 803.48 (14.05%) EURUSD: net profit...
Ignored

Nice work. My 2 cents. First off, period of testing is not nearly large enough. Second, every pair needs completely different params for every single condition applied. Hope it helps. Good luck.
If I don't mention SL and TP = longer-term setup possibly in the works!
 
 
  • Post #118
  • Quote
  • Apr 28, 2021 1:33pm Apr 28, 2021 1:33pm
  •  danjuma
  • | Joined Feb 2010 | Status: Member | 560 Posts
Quoting mtako
Disliked
{quote} Nice work. My 2 cents. First off, period of testing is not nearly large enough. Second, every pair needs completely different params for every single condition applied. Hope it helps. Good luck.
Ignored
Hi mtako. Thanks for your feedback. I agree the period of testing is too small. It was just a quick test (as I am using 'every tick' mode which can be painfully slow for long periods), and the EU and GU were trending similarly during that period (images attached. The first is GU, and the second is EU). I could have lived with slight differences but just completely baffled why one returned decent profit with low DD and the other would have actually blown the account!

Inserted Code
Second, every pair needs completely different params for every single condition applied.

And herein lies the big problem! How does one go about determining what params are optimum for what pairs! You can do an extensive back tests and come up with what you think are the optimal params but that does not guarantee it will not blow your account in future!

Attached Image (click to enlarge)
Click to Enlarge

Name: GU.JPG
Size: 72 KB
Attached Image (click to enlarge)
Click to Enlarge

Name: EU.JPG
Size: 77 KB
 
 
  • Post #119
  • Quote
  • Apr 28, 2021 2:15pm Apr 28, 2021 2:15pm
  •  mtako
  • Joined Sep 2020 | Status: Member | 3,124 Posts
Quoting danjuma
Disliked
{quote} Hi mtako. Thanks for your feedback. I agree the period of testing is too small. It was just a quick test (as I am using 'every tick' mode which can be painfully slow for long periods), and the EU and GU were trending similarly during that period (images attached. The first is GU, and the second is EU). I could have lived with slight differences but just completely baffled why one returned decent profit with low DD and the other would have actually blown the account! Second, every pair needs completely different params for every single...
Ignored
Its a pleasure danjuma

Every single thing from such backtest is completely meaningless so no need to be baffled. You need to work with minimum +1000(the more the better of course) of trades throughout as long a period as possible. Or else it is not even worth it.

Quoting danjuma
Disliked
{quote} I am using 'every tick' {image}{image}
Ignored
At beginning, no need to use tick mode when you have barely begun optimizing such a strategy.... 1min OHLC is more than enough. i would actually start with open price of an even bigger than 1m TF at beginning, for this strat.


Quoting danjuma
Disliked
{quote} Second, every pair needs completely different params for every single condition applied. And herein lies the big problem! How does one go about determining what params are optimum for what pairs! You can do an extensive back tests and come up with what you think are the optimal params but that does not guarantee it will not blow your account in future! {image}{image}
Ignored
The work has to be done, as simple as that. Go with mt5 and you will save yourself time and headaches.

Quoting danjuma
Disliked
{quote} You can do an extensive back tests and come up with what you think are the optimal params but that does not guarantee it will not blow your account in future! {image}{image}
Ignored
Of course, and the chance is much greater if you dont do all the necessary work. The work has to be done and only then will you know the stategys true potential and risk. I agree the past do not guarantee future results. That is why, at minimum, all the possible work has to be done. Only then, according to the results, comes the time to adapt it to its own optimal mm, then compliment it with other strategies and/or versions of the same strategy with different params from different TFs that have also done good enough for as long as it is possible to test.

Also, everything has to be dynamic... no fixed anything....

Its always a big job, that is why many just give up and convince themselves of all sorts of theories that there is no potential in eas.. The internet scammers dont help. But Ive been doing this a while and can tell you that, if the work is done, and in a smart, innovative way, and thoroughly, it is possible to get a consistently profitable and safe strategy going with good longterm return/drawdown ratio...

Just dont forget to diversify in the very end ! Every strategy has partner or more that makes it better!
If I don't mention SL and TP = longer-term setup possibly in the works!
 
1
  • Post #120
  • Quote
  • Apr 28, 2021 2:29pm Apr 28, 2021 2:29pm
  •  danjuma
  • | Joined Feb 2010 | Status: Member | 560 Posts
Many thanks for the feedback and tips mtako!
 
1
  • Trading Systems
  • /
  • The Ghillyoar System (buying highs and selling lows)
  • Reply to Thread
    • 1 45Page 678 10
    • 1 5Page 67 10
0 traders viewing now
  • More
Top of Page
  • Facebook
  • Twitter
About FF
  • Mission
  • Products
  • User Guide
  • Media Kit
  • Blog
  • Contact
FF Products
  • Forums
  • Trades
  • Calendar
  • News
  • Market
  • Brokers
  • Trade Explorer
FF Website
  • Homepage
  • Search
  • Members
  • Report a Bug
Follow FF
  • Facebook
  • Twitter

FF Sister Sites:

  • Metals Mine
  • Energy EXCH
  • Crypto Craft

Forex Factory® is a brand of Fair Economy, Inc.

Terms of Service / ©2022